hardcoded list of protocols for urlification is a maintenance burden and duplicate code
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Triaged
|
Low
|
Unassigned |
Bug Description
@staticmethod
+ def _linkify_
+ '''Don't linkify URIs consisting of just the protocol'''
+
+ blacklist_bases = [
+ 'about',
+ 'gopher',
+ 'http',
+ 'https',
+ 'sftp',
+ 'news',
+ 'ftp',
+ 'mailto',
+ 'irc',
+ 'jabber',
+ 'apt',
+ 'data',
+ ]
+
+ for base in blacklist_bases:
+ if url in ('%s' % base, '%s:' % base, '%s://' % base):
+ return True
+ return False
from
https:/
There's no need to manually list these, we should just use the url facilities to identify things without more than the scheme populated.
Changed in launchpad: | |
status: | New → Triaged |
importance: | Undecided → Low |
tags: | added: bugjam2010 |