ubuntu developers are not able to reject merge proposals on official packaging branches they can upload to ( IBranch.isPersonTrustedReviewer doesn't have logic for package branches )
Bug #618448 reported by
Benjamin Drung
This bug affects 5 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Triaged
|
High
|
Unassigned | ||
Bug Description
I cannot change the status of merge request to 'Rejected' (example [1]), but I can change the status to 'Work in progress', 'Needs review', and 'Merged'. I should be able to set the status, because I have the right to upload the package.
[1] https:/
Revision history for this message
| James Westby (james-w) wrote Re: IBranch.isPersonTrustedReviewer doesn't have logic for package branches | #1 |
| summary: |
- Cannot change status of merge request to 'Rejected' + IBranch.isPersonTrustedReviewer doesn't have logic for package branches |
| affects: | udd → launchpad-code |
| tags: | added: package-branches udd |
| Changed in launchpad-code: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| tags: | added: code-review |
| summary: |
- IBranch.isPersonTrustedReviewer doesn't have logic for package branches + ubuntu developers are not able to reject merge proposals on official + packaging branches they can upload to ( IBranch.isPersonTrustedReviewer + doesn't have logic for package branches ) |
To post a comment you must log in.
This is because Rejected is only valid if you are a "trusted reviewer" of the target branch.
Other ACL parts of LP (security.py) have special logic for official package branches, but
IBranch.
Thanks,
James