Launchpad itself

RotatableFileLogObserver is in the LP tree rather than in a reusable location

Bug #614275 reported by Julian Edwards
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
High
Unassigned

Bug Description

RotatableFileLogObserver is currently only tested in the buildd-manager tests in lib/lp/buildmaster. This is wrong for 2 reasons:

1. it relies on the behaviour of the buildd-manager
2. it's slow, because it waits several seconds for a logging event in the buildd-manager code

The tests should live in the lp.services.twistedsupport test code and use Deferreds or task.Clock() to avoid a long wait in the test. I have also disabled the tests in the buildd-manager test file because it's preventing me from landing a change that reduces the logging.

See original description
Julian Edwards (julian-edwards)
tags: added: tech-debt
Changed in soyuz:
status: New → Triaged
importance: Undecided → High
description: updated
summary: - RotatableLogFileObserver is tested in the wrong place
+ RotatableFileLogObserver is tested in the wrong place
Revision history for this message
Gary Poster (gary) wrote : Re: RotatableFileLogObserver is tested in the wrong place

From the perspective of the Foundations *team*, this is of low importance, because (a) we don't know the pertinent code, (b) we have plenty of other bits that we are working on, and (c) I can convince myself that Soyuz will be tackling it. :-P

It is a foundational bug since many teams rely on the code. (I kinda wish foundational-but-not-Foundations bugs were allowed to stay in Launchpad, but whatever.)

If the intent of assigning it to Foundations was to get the Foundations team to do something about it, please let me know.

Changed in launchpad-foundations:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Julian Edwards (julian-edwards) wrote : Re: [Bug 614275] Re: RotatableFileLogObserver is tested in the wrong place

On Friday 06 August 2010 22:07:30 you wrote:
> If the intent of assigning it to Foundations was to get the Foundations
> team to do something about it, please let

It wasn't! But there's nowhere else to file it unfortunately. I am hoping
that Henning will fix it since it's his code :)

Revision history for this message
Henning Eggers (henninge) wrote : Re: RotatableFileLogObserver is tested in the wrong place

I intend to fix it, yeah .... ;)

Revision history for this message
Robert Collins (lifeless) wrote :

So, we'll want this code outside of LP, it should be moved into e.g. twisted itself, or a txsupport or similar package. Since that implies fixing the test performance, I'm going to takeover this bug for that :)

summary: - RotatableFileLogObserver is tested in the wrong place
+ RotatableFileLogObserver is in the LP tree rather than in a reusable
+ location
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.