make a simple 'approve' on a merge cast an approve vote
Bug #603532 reported by
Robert Collins
This bug affects 3 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Triaged
|
Low
|
Unassigned | ||
Bug Description
On simple proposals folk may have nothing to say, but they have to do two things to meet the LP workflow : click 'approve' on the proposal as a whole and 'approve' as a vote for ec2land.
I think it would be reasonable that when someone clicks 'approve' on a merge proposal that they also implicitly and immediately cast an approve vote if they haven't already voted.
| tags: | added: code-review |
| Changed in launchpad-code: | |
| status: | New → Fix Committed |
| importance: | Undecided → Low |
| status: | Fix Committed → Triaged |
Revision history for this message
| Gerry Boland (gerboland) wrote | #1 |
To post a comment you must log in.
I want to cast my vote on this. This would be useful in case of unity-merger scripts, which add an "Approved by " string to the commit message, adding the names of people who voted approve.
For times when someone just approves the whole MR without voting, it means we get an empty "Approved by ." string.