Launchpad itself

Need to minify js files included in launchpad.js from app-specific js directories

Bug #592795 reported by Deryck Hodge
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Deryck Hodge
Launchpad itself 10.07

Bug Description

In moving files from lib/canonical/launchpad/javascript/bugs to lib/lp/bugs/javascript, I noticed that files from the app-specific locations were not being minified. This is because the non-minified files are being passed to bin/jsbuild rather the the minified ones.

Related branches

lp://staging/~deryck/launchpad/minify-app-specific-js-592795
Māris Fogels (community): Approve
Diff: 55 lines (+19/-4)
2 files modified
Makefile (+1/-1)
utilities/lp-deps.py (+18/-3)
Deryck Hodge (deryck)
Changed in launchpad-foundations:
status: New → In Progress
importance: Undecided → Low
Deryck Hodge (deryck)
Changed in launchpad-foundations:
milestone: none → 10.06
Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit

Fixed in stable r11009 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11009>

Changed in launchpad-foundations:
status: In Progress → Fix Committed
tags: added: qa-needstesting
Revision history for this message
Deryck Hodge (deryck) wrote :

Marking qa-ok since this is Makefile and build script changes and it has passed a round or two of buildbot.

tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in launchpad-foundations:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.