Launchpad itself

OOPS accessing +new-recipe page not logged in

Bug #583395 reported by Diogo Matsubara
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Paul Hummer
Launchpad itself 10.07

Bug Description

As seen on OOPS-1601EB362 an AttributeError: 'NoneType' object has no attribute 'find' was raised while accessing the +new-recipe page anonymously.

To reproduce:
1. Make sure you're not logged in
2. Open https://code.edge.launchpad.net/~ubuntu-branches/ubuntu/lucid/wine/lucid/+new-recipe
3. OOPS-1601EC781

Related branches

lp://staging/~rockstar/launchpad/fix-broken-recipes
Francis J. Lacoste (community): Approve
Tim Penhey (community): Approve
Diff: 63 lines (+19/-3)
2 files modified
lib/lp/code/browser/configure.zcml (+2/-2)
lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+17/-1)
Tim Penhey (thumper)
tags: added: recipe
Changed in launchpad-code:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Paul Hummer (rockstar) wrote :

So, I think the best solution here is to make it so that the person can't naturally get to this page when they aren't logged in, and to not show this view at all when they are not logged in. Give them a 403 or something, but this page shouldn't be available to those not logged in.

Revision history for this message
Tim Penhey (thumper) wrote : Re: [Bug 583395] Re: OOPS accessing +new-recipe page not logged in

On Mon, 31 May 2010 03:15:57 you wrote:
> So, I think the best solution here is to make it so that the person
> can't naturally get to this page when they aren't logged in, and to not
> show this view at all when they are not logged in. Give them a 403 or
> something, but this page shouldn't be available to those not logged in.

Make the page only available to launchpad.AnyPerson. If the link is shown,
but the view needs a login, it will prompt the user for a login.

I think this is the best approach.

Paul Hummer (rockstar)
Changed in launchpad-code:
status: Triaged → In Progress
assignee: nobody → Paul Hummer (rockstar)
Revision history for this message
Paul Hummer (rockstar) wrote :

Fixed in devel revno 10940

Changed in launchpad-code:
status: In Progress → Fix Committed
Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit

Fixed in stable r10940 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10940>

Changed in launchpad-code:
milestone: none → 10.05
tags: added: qa-needstesting
Ursula Junque (ursinha)
Changed in launchpad-code:
milestone: 10.05 → 10.06
Revision history for this message
Ursula Junque (ursinha) wrote :

Is bug 590993 really a dupe of this one? Is that a side effect or part of this problem? Because I was logged in to reproduce that KeyError OOPS.

Paul Hummer (rockstar)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.