two notifications for review approval by single person

Bug #562593 reported by Robert Collins
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
High
Unassigned

Bug Description

 affects launchpad-code
 done

On my merge proposal
https://code.edge.launchpad.net/~lifeless/launchpad/bug-562058/+merge/23294

I received two notifications when it was approved. One read:"""

The proposal to merge lp:~lifeless/launchpad/bug-562058 into
lp:launchpad has been updated.

    Status: Needs review => Approved
"""

The other read: """
Review: Approve
Looks fine, can you land this yourself? Otherwise I can of course.

The diff on this page is very odd, I wonder what happened there.
"""

Note that this isn't the same as 'I got two emails for each
notification', this is 'I was notified twice by a single person
reviewing and approving the proposal' - with the combined result that I
got four emails ;).

I realise that this is due to the split between review comment and
proposal status, but its still undesirable, in email, to be quite this
chatty.

-Rob

Paul Hummer (rockstar)
Changed in launchpad-code:
importance: Undecided → High
status: New → Triaged
Revision history for this message
Robert Collins (lifeless) wrote :

event combining would address this

tags: added: email notifications
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.