buildd-manager should log details of builds that it collects from the slave
Bug #530040 reported by
Julian Edwards
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Julian Edwards | ||
Bug Description
If you watch the log output for buildd-manager, you'll quickly discover that it's about as useful as a chocolate fireguard. There are certain periods where it appears to hang and then jumps into action.
These periods are where it's collecting a build from a slave and calling Popen() on process-upload.py.
The code should log these important steps:
1. Job dispatch (which it already does)
2. Job collection
3. Invocation of process-upload and its command line parameters.
Related branches
lp://staging/~julian-edwards/launchpad/buildd-manager-better-logging-bug-530040
- Abel Deuring (community): Approve (code)
-
Diff: 191 lines (+24/-18)5 files modifiedlib/lp/buildmaster/interfaces/buildbase.py (+4/-1)
lib/lp/buildmaster/manager.py (+5/-5)
lib/lp/buildmaster/master.py (+1/-1)
lib/lp/buildmaster/model/buildbase.py (+11/-8)
lib/lp/buildmaster/model/builder.py (+3/-3)
Revision history for this message
| Julian Edwards (julian-edwards) wrote | #1 |
| tags: | added: buildd-manager |
| Changed in soyuz: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| milestone: | none → 10.03 |
| assignee: | nobody → Julian Edwards (julian-edwards) |
| Changed in soyuz: | |
| status: | Triaged → In Progress |
Revision history for this message
| Julian Edwards (julian-edwards) wrote | #2 |
| Changed in soyuz: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #3 |
| tags: | added: qa-needstesting |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in soyuz: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
It should also be less spammy when logging periodic scans.