PPAs owned by others link me to upload instructions

Alright so what happens if we just add another line to the mechanism
that figures out if you have upload rights to a ppa or not, saying
something like "You don't have upload rights to this package, please
contact the_owner for something ..." Does that maybe perhaps clarify
this

--
Regards,
Vikram Dhillon

~~~
There are lots of Linux users who don't care how the kernel works, but
only want to use it. That is a tribute to how good Linux is.
-- Linus Torvalds

On Thu, Feb 4, 2010 at 5:05 AM, Julian Edwards
<email address hidden> wrote:
> ** Changed in: soyuz
>       Status: New => Triaged
>
> ** Changed in: soyuz
>   Importance: Undecided => Low
>
> ** Tags added: ppa ui
>
> --
> PPAs owned by others link me to upload instructions
> https://bugs.launchpad.net/bugs/516821
> You received this bug notification because you are subscribed to Soyuz.
>
> Status in Soyuz - The Launchpad Package Manager: Triaged
>
> Bug description:
> If I visit the index page for a PPA that I have no upload rights to, it tells me "Find more information about how to upload packages in the PPA help page." That's not useful.
>
>
>

Hi Vikram,

This is only appearing when the PPA being viewed is not active (ie. nothing currently published to it), from lib/lp/soyuz/templates/archive-index.pt

      <p tal:condition="not: archive_active">
        This PPA does not contain any packages yet. Find more
        information about how to upload packages in the
        <a href="https://help.launchpad.net/Packaging/PPA"
           target="help">PPA help page</a>.</p>

I think we should just add an extra condition for the "Find more information..." bit. So by default a non-active PPA will display the general message "This PPA does not ....", but if you are an uploader (see the ppa-upload-hint-portlet for an eg of this condition), you'll also see the further sentence with the link to the help? What do you think?

@Michael: Nice job, I was looking for this line of code but was having a hard time in finding it :) Alright so something like this maybe perhaps:

     # Here's what I can't figure out
     <p tal:condition="self.context.owner???"
         class="message warning">

         You don't have upload rights to this package, please
contact <a tal:replace="structure context/owner/fmt:link"></a> for something ...</p>

      <p>You can upload packages to this PPA using:</p>

      <p><tt>dput <tal:ppa-ref replace="view/ppa_reference"
                    >ppa:cprov/ppa</tal:ppa-ref> &lt;source.changes&gt;</tt>
            (<a href="https://help.launchpad.net/Packaging/PPA/Uploading"
               >Read about uploading</a>)</p>

Thanks for working on this Vikram!

So, first, I don't think we need the "You don't have upload rights to this package, please contact ownername" etc., but instead simply move the paragraph that says: "For questions and bugs with software in this PPA, please contact ownername" down so that it it always displayed in the portlet (whether it's active or not).

So the user (without upload privs) would see something like the following in the "Adding this PPA to your system" portlet:
{{{
This PPA does not contain any packages yet.

For questions and bugs with software in this PPA, please contact ...
}}}

(hrm, we might be best updating that text to "For general questions or bugs with software in this PPA, please contact...").

Does that make sense? Once you've got it working, do a screenshot and attach it here - once the UI is finalised it'll be time to write the pagetests to ensure it stays that way :)

Oh, and after looking again, I believe we can simply *delete* the reference to the uploading help there, as it's already presented in the ppa-upload-hint-portlet which will be displayed to uploaders.