Launchpad itself

SourcePackageRecipeBuildJob should be derived from BuildFarmJob

Bug #508238 reported by Muharem Hrnjadovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Muharem Hrnjadovic
Launchpad itself 10.01

Bug Description

`BuildFarmJob` provides default implementations for quite a few "generic" methods. That's why all XXXBuildJob classes should be derived from it.

See original description

Related branches

lp://staging/~al-maisan/launchpad/empty-table-507782
Canonical Launchpad Engineering: Pending requested
Diff: 359 lines (+120/-38)
8 files modified
lib/lp/buildmaster/interfaces/buildfarmjob.py (+17/-11)
lib/lp/buildmaster/model/builder.py (+3/-9)
lib/lp/buildmaster/model/buildfarmjob.py (+1/-1)
lib/lp/buildmaster/tests/test_builder.py (+66/-6)
lib/lp/soyuz/configure.zcml (+3/-0)
lib/lp/soyuz/model/buildpackagejob.py (+5/-5)
lib/lp/soyuz/model/sourcepackagerecipebuild.py (+8/-5)
lib/lp/testing/factory.py (+17/-1)
Revision history for this message
Muharem Hrnjadovic (al-maisan) wrote :

Related to bug #507782.

Changed in soyuz:
status: New → Triaged
importance: Undecided → High
milestone: none → 10.01
tags: added: buildfarm wellington
Revision history for this message
Muharem Hrnjadovic (al-maisan) wrote :

It also requires the following registration:

=== modified file 'lib/lp/soyuz/configure.zcml'
--- lib/lp/soyuz/configure.zcml 2010-01-13 22:16:04 +0000
+++ lib/lp/soyuz/configure.zcml 2010-01-16 02:48:23 +0000
@@ -960,6 +960,9 @@
        class="lp.soyuz.model.sourcepackagerecipebuild.SourcePackageRecipeBuildJob">
       <allow interface="lp.soyuz.interfaces.sourcepackagerecipebuild.ISourcePackageRecipeBuildJob"/>
     </class>
+ <utility component="lp.soyuz.model.sourcepackagerecipebuild.SourcePackageRecipeBuildJob"
+ name="RECIPEBRANCHBUILD"
+ provides="lp.buildmaster.interfaces.buildfarmjob.IBuildFarmJob"/>

     <securedutility
        component="lp.soyuz.model.sourcepackagerecipebuild.SourcePackageRecipeBuildJob"

Muharem Hrnjadovic (al-maisan)
description: updated
Muharem Hrnjadovic (al-maisan)
Changed in soyuz:
status: Triaged → In Progress
assignee: nobody → Muharem Hrnjadovic (al-maisan)
Revision history for this message
Diogo Matsubara (matsubara) wrote : Bug fixed by a commit

Fixed in db r8888 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-devel/revision/8888>

Changed in soyuz:
status: In Progress → Fix Committed
Muharem Hrnjadovic (al-maisan)
Changed in soyuz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.