Launchpad itself

findBuildCandidate() doesn't work for recipe builds

Bug #507782 reported by Julian Edwards
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Muharem Hrnjadovic
Launchpad itself 10.01

Bug Description

findBuildCandidate() doesn't work for recipe builds. It completely fails to pick up the outstanding build request.

Related branches

lp://staging/~al-maisan/launchpad/empty-table-507782
Canonical Launchpad Engineering: Pending requested
Diff: 359 lines (+120/-38)
8 files modified
lib/lp/buildmaster/interfaces/buildfarmjob.py (+17/-11)
lib/lp/buildmaster/model/builder.py (+3/-9)
lib/lp/buildmaster/model/buildfarmjob.py (+1/-1)
lib/lp/buildmaster/tests/test_builder.py (+66/-6)
lib/lp/soyuz/configure.zcml (+3/-0)
lib/lp/soyuz/model/buildpackagejob.py (+5/-5)
lib/lp/soyuz/model/sourcepackagerecipebuild.py (+8/-5)
lib/lp/testing/factory.py (+17/-1)
Revision history for this message
Muharem Hrnjadovic (al-maisan) wrote :

_findBuildCandiate() subqueries returned by spefic job classes may fail the overall query if any of the tables in the resulting FROM clause is empty.

The fix needs to make sure that the overall query is not rendered invalid by empty tables listed in the FROM clause.

Changed in soyuz:
status: Triaged → In Progress
milestone: none → 10.01
tags: added: buildfarm
Revision history for this message
Diogo Matsubara (matsubara) wrote : Bug fixed by a commit

Fixed in db r8888 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-devel/revision/8888>

Changed in soyuz:
status: In Progress → Fix Committed
Muharem Hrnjadovic (al-maisan)
Changed in soyuz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.