Launchpad itself

There is no review list which can be sensibly driven to zero by a team

Bug #507319 reported by James Westby
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
High
Unassigned

Bug Description

+activereviews doesn't really work as a work queue. It would be awesome to have something that does (perhaps by tweaking +activereviews, perhaps by making a new page).

One way would be a paginated list under /people/+me showing:
 * Only Needs-review reviews
 * Things the person is reviewing which have either comments or new commits from the submitter.
 * Then things the person has been asked to review directly
 * Then things that a team they are in has been asked to review (with smaller teams first)
 * Oldest reviews first within those groups.

See original description
Revision history for this message
Martin Pool (mbp) wrote : Re: [Bug 507319] [NEW] Please create a +pendingreviews page

Why not just ask for activereviews to be batched?

- Martin

On 14/01/2010 3:00 PM, "James Westby"
<<email address hidden><jw%<email address hidden>>>
wrote:

Public bug reported:

This would be a page like +activereviews but would allow pagingation.

It would show the reviews requested for a person which were in "Needs
Review", sorting those which that person was directly asked to review above
those that were requested from a team that person is a member of. It would
then sort oldest first within those groups.

This would allow for pagination if done right, and so could be used for
large
teams.

Thanks,

James

** Affects: launchpad-code
    Importance: Undecided
        Status: New

--
Please create a +pendingreviews page
https://bugs.launchpad.net/bugs/507319
You received this bug notification because you are subscribed to
Launchpad Bazaar Integration.

Revision history for this message
James Westby (james-w) wrote :

On Thu, 14 Jan 2010 05:15:54 -0000, Martin Pool <email address hidden> wrote:
> Why not just ask for activereviews to be batched?

Paginating three sets is tough. Tim said that this would be a more
scalable approach. I think having more pages isn't great, but if the
existing one can't do what we need...

Thanks,

James

Revision history for this message
Tim Penhey (thumper) wrote :

On Thu, 14 Jan 2010 18:15:54 Martin Pool wrote:
> Why not just ask for activereviews to be batched?

There are six different lists on the active reviews page, which are determined
by interrogating the realized objects. This doesn't scale.

What is being proposed will only show reviews where the person (or team) has
been asked to review. Effectively a pure drive to zero list.

Tim Penhey (thumper)
Changed in launchpad-code:
status: New → Triaged
importance: Undecided → High
tags: added: code-review udd
Robert Collins (lifeless)
summary: - Please create a +pendingreviews page
+ Please create a drive to zero list of reviews for a team
summary: - Please create a drive to zero list of reviews for a team
+ There is no review list which can be sensibly driven to zero by a team
description: updated
Robert Collins (lifeless)
description: updated
Revision history for this message
Robert Collins (lifeless) wrote :

Making +active reviews paginated may help with +activereviews pagination. I think a good starting point for this would be to make the sort order of each collection db backed, and use separate batching collections on the page. That would increase (but keep static) the number of queries, but each query would be simpler. This should still be able to be done efficiently, given that the point of a drive-to-zero queue is to be small.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.