| 2009-12-23 09:01:50 |
Michael Nelson |
bug |
|
|
added bug |
| 2009-12-23 09:11:57 |
Michael Nelson |
description |
Hi,
I have locally (on my home system) packaged Schools Wikipedia. Schools Wikipedia is a subselection of all Wikipedia Articles, based on the UK National Curriculum, which has been audited by SOS Childrens Villages volunteers. So it's supposed to be child safe, and any big mistakes have been checked/removed.
http://schools-wikipedia.org/
The problem is, that the sources all together are 3GB, and the resulting package is also 3GB (it's architecture independent), so if I were to submit this package, I would need an extra 6GB of PPA space.
Thanks for your consideration,
Pascal de Bruijn
|
This bug came out of https://answers.edge.launchpad.net/soyuz/+question/93944 where a person was uploading a 3gb source package and was not receiving any upload error even though the file uploaded successfully.
The following log shows the exception while processing the upload:
http://pastebin.ubuntu.com/345209/
and the actual traceback is:
http://launchpadlibrarian.net/36972844/mfPJuIGJVq6E7KhT95s1WLCuKJn.txt
which shows that "DataError: integer out of range" is raised - I assume because we're using psql's (signed) 4byte integer to store the file size (max. 2147483648 bytes).
If we would like to be able to support situations like that described in the bug (large source pkgs in exceptional circumstances) it would be great to update this to a bigint or something, but either way, we should be checking the upper bound of the filesize and raising an appropriate UploadFailed exception to be handled by the callsite.
If someone is keen for a trivial bug, it's just one extra guard check in canonical.librarian.FileUploadClient.addFile().
|
|
| 2009-12-23 09:12:39 |
Michael Nelson |
affects |
soyuz |
launchpad-foundations |
|
| 2009-12-23 09:59:47 |
Stuart Bishop |
description |
This bug came out of https://answers.edge.launchpad.net/soyuz/+question/93944 where a person was uploading a 3gb source package and was not receiving any upload error even though the file uploaded successfully.
The following log shows the exception while processing the upload:
http://pastebin.ubuntu.com/345209/
and the actual traceback is:
http://launchpadlibrarian.net/36972844/mfPJuIGJVq6E7KhT95s1WLCuKJn.txt
which shows that "DataError: integer out of range" is raised - I assume because we're using psql's (signed) 4byte integer to store the file size (max. 2147483648 bytes).
If we would like to be able to support situations like that described in the bug (large source pkgs in exceptional circumstances) it would be great to update this to a bigint or something, but either way, we should be checking the upper bound of the filesize and raising an appropriate UploadFailed exception to be handled by the callsite.
If someone is keen for a trivial bug, it's just one extra guard check in canonical.librarian.FileUploadClient.addFile().
|
We currently store the file size of Librarian files in the database using a normal PostgreSQL integer. This does not support files larger than 2GB. We should switch this column to bigint to support DVD images or huge source packages, such as discussed in https://answers.edge.launchpad.net/soyuz/+question/93944 where a person was uploading a 3gb source package and was not receiving any upload error even though the file uploaded successfully.
The following log shows the exception while processing the upload:
http://pastebin.ubuntu.com/345209/
and the actual traceback is:
http://launchpadlibrarian.net/36972844/mfPJuIGJVq6E7KhT95s1WLCuKJn.txt
which shows that "DataError: integer out of range" is raised because we're using PostgreSQL's (signed) 4byte integer to store the file size (max. 2147483648 bytes).
|
|
| 2009-12-23 09:59:52 |
Stuart Bishop |
launchpad-foundations: status |
New |
Confirmed |
|
| 2009-12-23 09:59:56 |
Stuart Bishop |
launchpad-foundations: importance |
Undecided |
Medium |
|
| 2009-12-23 09:59:59 |
Stuart Bishop |
launchpad-foundations: assignee |
|
Stuart Bishop (stub) |
|
| 2009-12-23 10:00:07 |
Stuart Bishop |
launchpad-foundations: milestone |
|
10.01 |
|
| 2009-12-23 10:15:33 |
Stuart Bishop |
launchpad-foundations: status |
Confirmed |
In Progress |
|
| 2009-12-23 10:15:26 |
Launchpad Janitor |
branch linked |
|
lp:~stub/launchpad/pending-db-changes |
|
| 2010-01-06 12:07:53 |
Stuart Bishop |
launchpad-foundations: status |
In Progress |
Fix Committed |
|
| 2010-01-28 01:49:37 |
Curtis Hovey |
launchpad-foundations: status |
Fix Committed |
Fix Released |
|
| 2010-03-26 10:10:18 |
Stuart Bishop |
branch unlinked |
lp:~stub/launchpad/pending-db-changes |
|
|
