Launchpad's archive mirror prober only handles 200 OK responses

Bug #433481 reported by Jonathan Davies
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

According to lib/lp/registry/scripts/distributionmirror_prober.py, lines 108-116:

    def handleStatus(self, version, status, message):
        # According to http://lists.debian.org/deity/2001/10/msg00046.html,
        # apt intentionally handles only '200 OK' responses, so we do the
        # same here.
        if status == str(httplib.OK):
            self.factory.succeeded(status)
        else:
            self.factory.failed(Failure(BadResponseCode(status)))
        self.transport.loseConnection()

However, from Ubuntu Jaunty onwards, this is no longer the case as apt now supports redirects (see bug #18645) and some mirrors may decide to take advantage of this "feature", for which ever reasons, and the mirror prober would fail on their mirrors.

Revision history for this message
Jonathan Davies (jpds) wrote :

Upon further inspection of the code, it looks like the archive prober could be adapted to use RedirectAwareProberProtocol() function.

summary: - Launchpad's mirror prober only handles 200 OK responses
+ Launchpad's archive mirror prober only handles 200 OK responses
Changed in launchpad-registry:
status: New → Triaged
Curtis Hovey (sinzui)
Changed in launchpad-registry:
importance: Undecided → Low
Jonathan Davies (jpds)
tags: added: mirror
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.