Launchpad itself

Fix Committed should get the karma

Bug #403554 reported by Barry Warsaw
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Curtis Hovey
Launchpad itself 10.01

Bug Description

Currently Launchpad assigns karma to the person who sets a bug status to Fix Released, while the person who sets it to Fix Committed gets no karma. This is bong.

Use case: Jane works hard to develop a fix for bug 1, shepherds that branch through review, and finally lands it. She "closes" the bug by setting the status to Fix Committed. However, the version of the software with the bug fix is not yet released.

Months later, Joe the Release Manager, packages up the new version of the software and makes a release, setting the bug status to Fix Released.

Joe should get some karma for his actions as release manager, but not the karma for fixing the bug. Jane should get karma for fixing the bug.

Tags: karma lp-bugs

Related branches

lp://staging/~sinzui/launchpad/release-love
Eleanor Berger (community): Approve
Diff: 262 lines (+73/-24)
10 files modified
database/schema/security.cfg (+3/-0)
lib/canonical/launchpad/subscribers/karma.py (+8/-2)
lib/lp/bugs/doc/malone-karma.txt (+32/-1)
lib/lp/registry/browser/productrelease.py (+0/-5)
lib/lp/registry/browser/tests/productrelease-views.txt (+0/-6)
lib/lp/registry/doc/milestone.txt (+23/-0)
lib/lp/registry/model/milestone.py (+6/-2)
lib/lp/registry/stories/productrelease/xx-productrelease-basics.txt (+0/-6)
lib/lp/registry/stories/productrelease/xx-productrelease-view.txt (+0/-1)
lib/lp/registry/templates/milestone-index.pt (+1/-1)
Graham Binns (gmb)
Changed in launchpad:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Diogo Matsubara (matsubara) wrote :

I run a script from devpad that scans LP branches for fixed bugs and mark those as fix committed. I don't think I deserve any karma for this action but if this fix is implemented, I'll get tons of karma unfairly. Please accommodate use cases like the one I just described. Maybe we should take into account who's the assignee when the bug is fix committed and then award karma to the assignee.

affects: launchpad → malone
tags: added: karma
Revision history for this message
Jonathan Lange (jml) wrote :

Joe should definitely get karma for the release. After all, it's not fixed until it's actually in users' hands.

Revision history for this message
Curtis Hovey (sinzui) wrote :

Joe should get karma for creating the release from the milestone, but registry does not award karma at this time. I think making the release is a spearate issue. In the bugs domain the release manager gets karma for the importance change, and stautes invalid and confirmed. (yes, read that carfuly. release managers use triaged, and Joe does not get credit for that.)

I think the bug's bugfixed karma action should go to the bug assignee because he was responsible for doing the extra work of planning, meetings, reviews, etc.

If the bug has no assignee, then it should go to the user user changing the status. This allows the release mangager to assign and close a bug to give credit to users who fixed secondary bugs while working on the primary bug.

Curtis Hovey (sinzui)
Changed in malone:
status: Triaged → In Progress
assignee: nobody → Curtis Hovey (sinzui)
milestone: none → 10.01
Revision history for this message
Curtis Hovey (sinzui) wrote :

Fixed in db-devel r8923.

Changed in malone:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.