Launchpad itself

a way to submit a patch to be merged without going through code review

Bug #399318 reported by John A Meinel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

You might want to mark this as Won't Fix or Invalid, but it is at least something to consider.

Occasionally it is useful to submit trivial work directly to the mainline without going through a formal review process. This is either because it really is trivial (simple typo fixes, etc), or because you are tweaking a patch that is already reviewed.

As tarmac only uses the launchpad code review for its queue-of-things-to-merge you have to go through the full process.

One possibility to at least make it lighter weight is if you could propose a merge request and mark it as 'approved' in the same step. (Or at least as approved before the diff email gets sent out....)

Just some thoughts.

Tags: lp-code
Paul Hummer (rockstar)
Changed in tarmac:
status: New → Triaged
affects: tarmac → launchpad-code
Changed in launchpad-code:
status: Triaged → New
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

My instinctive response to this is that it would be better to make the full workflow so slick and awesome that we don't feel the need for something like this.

Revision history for this message
John A Meinel (jameinel) wrote : Re: [Bug 399318] Re: a way to submit a patch to be merged without going through code review

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Michael Hudson wrote:
> My instinctive response to this is that it would be better to make the
> full workflow so slick and awesome that we don't feel the need for
> something like this.
>

Absolutely, as long as you can define what such a slick-and-awesome
workflow would look like. :)

Certainly at the moment resubmitting for a trivial fix generates 3
emails, 4 if you want to include a comment. Which is 2 more than "submit
this, someone else reviews and approves". Certainly IMO resubmitting
seems like it should be less overhead than an original submission.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpeR0wACgkQJdeBCYSNAAMnMACeLVg8UFjzOpu7LWq+OSOanDJ0
GAsAoNE0FpSrRrPOryubx0LMrm4b1YT3
=n+Vn
-----END PGP SIGNATURE-----

Revision history for this message
Aaron Bentley (abentley) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John A Meinel wrote:
> Michael Hudson wrote:
>> My instinctive response to this is that it would be better to make the
>> full workflow so slick and awesome that we don't feel the need for
>> something like this.
>
>
> Absolutely, as long as you can define what such a slick-and-awesome
> workflow would look like. :)
>
> Certainly at the moment resubmitting for a trivial fix generates 3
> emails, 4 if you want to include a comment. Which is 2 more than "submit
> this, someone else reviews and approves". Certainly IMO resubmitting
> seems like it should be less overhead than an original submission.

I think resubmit can be improved beyond the improvements we could make
to improve the whole workflow.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpeSsYACgkQ0F+nu1YWqI0IeQCeJlqNKoa8JR2EURSrNO25ay4W
A2wAn0Cgd0LxT2eP9xoJ6ufbenCKwEWp
=OQeH
-----END PGP SIGNATURE-----

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.