Wrong spark lines shown if dev focus branch not first
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Paul Hummer |
Bug Description
https:/
This is due to the following code getting the the json_url from the first branch, rather than checking which branch it should be getting it from. Which brings up another bug, only one spark line is shown even if I have subscribed to many branches that are development focus branches.
function renderSpark() {
spark_div = 'dev_focus_spark';
if(Y.get('#' + spark_div) !== null) {
json_url = branch_
var container = spark_div;
var uri = json_url;
var xhr_config = {
on: {
},
}
};
Y.io(uri, xhr_config);
}
}
Changed in launchpad-code: | |
milestone: | 2.2.6 → 2.2.7 |
Changed in launchpad-code: | |
assignee: | Martin Albisetti (beuno) → Paul Hummer (rockstar) |
Changed in launchpad-code: | |
status: | Triaged → In Progress |
Changed in launchpad-code: | |
status: | In Progress → Fix Committed |
Changed in launchpad-code: | |
status: | Fix Committed → Fix Released |
Martin, I'm assigning it to you as we need to decide how many to show, and also how to fire off a whole pile of non-blocking update requests (if sending off multiple).