Launchpad itself

Reviewing on behalf of a team leaves no indication you did so in the UI

Bug #342018 reported by James Westby
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

Hi,

This is related to bug 307461 and bug 315123.

If I go to a merge proposal where I am part of the team that the merge was
requested from I see something like:

  Bazaar Developers [Review]
  James Westby [Review]

If I choose to review on behalf of the team it becomes

  James Westby Approved

This leaves no clue in the UI that I did the review on behalf of the team,
which is interesting information. While it may perhaps be conveyed by the
fact that there are no other reviews requested, this falls down if there are
multiple reviews requested.

My instinct would be the following

  James Westby on behalf of Bazaar Developers Approved

Thanks,

James

Revision history for this message
Jonathan Lange (jml) wrote :

Yeah, this is an interesting bug.

Martin Albisetti & Tim, what do you think?

Changed in launchpad-bazaar:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Aaron Bentley (abentley) wrote :

I'm not sure whether it's ever been defined whether such a review is
- a review from a member of a team or
- a review on behalf of a team

Revision history for this message
Tim Penhey (thumper) wrote : Re: [Bug 342018] Re: Reviewing on behalf of a team leaves no indication you did so in the UI

On Fri, 21 Aug 2009 08:52:40 Aaron Bentley wrote:
> I'm not sure whether it's ever been defined whether such a review is
> - a review from a member of a team or
> - a review on behalf of a team

I think the best solution to this is to add a field to the vote summary that
indicates who the review is on behalf of.

That way if the reviewer ended up specifying tags that meant that the team
review was not picked up automatically, we could still allow the user to
"claim" the team review, and record that their review was effectively on behalf
of that team. Also if we record this, we can show it in the summary as well.

  Review: Approve (on behalf of The Launchpad Hackers)

or something.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.