| 2008-11-27 19:05:56 |
Tom Haddon |
bug |
|
|
added bug |
| 2008-11-27 19:13:37 |
Eleanor Berger |
launchpad: bugtargetdisplayname |
Launchpad itself |
Launchpad Registry |
|
| 2008-11-27 19:13:37 |
Eleanor Berger |
launchpad: bugtargetname |
launchpad |
launchpad-registry |
|
| 2008-11-27 19:13:37 |
Eleanor Berger |
launchpad: statusexplanation |
|
|
|
| 2008-11-27 19:13:37 |
Eleanor Berger |
launchpad: title |
Bug #302897 in Launchpad itself: "Private teams don't satisfy ValidPersonOrTeam, so can't set them as bug supervisor (or set private bugs for a project they registered)" |
Bug #302897 in Launchpad Registry: "Private teams don't satisfy ValidPersonOrTeam, so can't set them as bug supervisor (or set private bugs for a project they registered)" |
|
| 2008-11-27 19:38:10 |
Graham Binns |
launchpad-registry: status |
New |
In Progress |
|
| 2008-11-27 19:38:10 |
Graham Binns |
launchpad-registry: assignee |
|
gmb |
|
| 2008-11-27 19:38:10 |
Graham Binns |
launchpad-registry: importance |
Undecided |
High |
|
| 2008-11-27 19:38:10 |
Graham Binns |
launchpad-registry: statusexplanation |
|
This also prevents bugs from being set as private manually once the Bug Supervisor has been set (at the DB level) to the private team. Marking this as high as its affecting an internal Canonical team. |
|
| 2008-11-27 19:38:10 |
Graham Binns |
launchpad-registry: milestone |
|
2.1.12 |
|
| 2008-11-27 23:26:39 |
Graham Binns |
launchpad-registry: status |
In Progress |
Triaged |
|
| 2008-11-27 23:26:39 |
Graham Binns |
launchpad-registry: statusexplanation |
This also prevents bugs from being set as private manually once the Bug Supervisor has been set (at the DB level) to the private team. Marking this as high as its affecting an internal Canonical team. |
So, I've done some digging around and discovered there are a couple of problems:
1. in ValidPersonOrTeamVocabulary._doSearch() we don't return non-Public Persons. This makes sense if we're going to hide private teams but since we don't it seems a little odd.
2. in validators.validate_public_person() we deliberately prevent the linkage of non-Public Persons (well, the code that does the prevention is in is_valid_public_person().
The attached branch addresses these problems (though no tests were changed; I was just hacking about). If anyone wants to take this and run with it before the end of the weekend, feel free, otherwise I'll finish it on Monday. |
|
| 2008-11-27 23:26:59 |
Graham Binns |
launchpad-registry: status |
Triaged |
In Progress |
|
| 2008-11-27 23:26:59 |
Graham Binns |
launchpad-registry: statusexplanation |
So, I've done some digging around and discovered there are a couple of problems:
1. in ValidPersonOrTeamVocabulary._doSearch() we don't return non-Public Persons. This makes sense if we're going to hide private teams but since we don't it seems a little odd.
2. in validators.validate_public_person() we deliberately prevent the linkage of non-Public Persons (well, the code that does the prevention is in is_valid_public_person().
The attached branch addresses these problems (though no tests were changed; I was just hacking about). If anyone wants to take this and run with it before the end of the weekend, feel free, otherwise I'll finish it on Monday. |
Still in progress; me silly. |
|
| 2008-12-01 10:44:03 |
Graham Binns |
launchpad-registry: status |
In Progress |
Triaged |
|
| 2008-12-01 10:44:03 |
Graham Binns |
launchpad-registry: assignee |
gmb |
|
|
| 2008-12-01 10:44:03 |
Graham Binns |
launchpad-registry: statusexplanation |
Still in progress; me silly. |
Okay, I'm unassigning this from myself since I don't really have the domain nouse to fix the problem (and there's something a bit more in depth needed here in terms of deciding how to handle these links properly).
I'll leave it targeted to LP-Registry 2.1.12 for now to be retargeted later as needed. |
|
| 2008-12-18 04:31:56 |
Curtis Hovey |
launchpad-registry: statusexplanation |
Okay, I'm unassigning this from myself since I don't really have the domain nouse to fix the problem (and there's something a bit more in depth needed here in terms of deciding how to handle these links properly).
I'll leave it targeted to LP-Registry 2.1.12 for now to be retargeted later as needed. |
We have a story of for obfuscating private name that may solve this bug. I believe we can implement this new feature for the first release of 2009. |
|
| 2008-12-18 04:31:56 |
Curtis Hovey |
launchpad-registry: milestone |
2.1.12 |
2.2.1 |
|
| 2008-12-31 15:39:06 |
Curtis Hovey |
launchpad-registry: assignee |
|
bac |
|
| 2008-12-31 15:39:06 |
Curtis Hovey |
launchpad-registry: statusexplanation |
We have a story of for obfuscating private name that may solve this bug. I believe we can implement this new feature for the first release of 2009. |
|
|
| 2009-01-29 11:37:54 |
Curtis Hovey |
launchpad-registry: milestone |
2.2.1 |
2.2.2 |
|
| 2009-02-23 20:09:04 |
Curtis Hovey |
launchpad-registry: milestone |
2.2.2 |
2.2.3 |
|
| 2009-03-18 19:57:07 |
Brad Crittenden |
launchpad-registry: status |
Triaged |
In Progress |
|
| 2009-03-31 16:36:30 |
Curtis Hovey |
launchpad-registry: milestone |
2.2.3 |
2.2.4 |
|
| 2009-04-06 15:52:59 |
Edwin Grubbs |
launchpad-registry: status |
In Progress |
Fix Committed |
|
| 2009-04-15 13:10:43 |
Curtis Hovey |
tags |
|
story-private-teams |
|
| 2009-04-30 15:15:21 |
Curtis Hovey |
launchpad-registry: status |
Fix Committed |
Fix Released |
|
