Requesting a review doesn't talk much about reviewing

Bug #297674 reported by Björn Tillenius
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

When you finish a branch, you want to want to request a review for it. Now, how do you do that? Well, you... propose the branch for merging into another branch? That's not very intuitive, and I doubt people will find it.

Having the UI talk about requesting a review for the branch would be better, since that's what you usually do.

Further more, the mail notifications that get sent should also talk about reviews. If you get an e-mail saying that someone proposed to merge a branch into another one, it doesn't tell you that it needs to be reviewed.

Jonathan Lange (jml)
Changed in launchpad-bazaar:
importance: Undecided → High
status: New → Triaged
Revision history for this message
Tim Penhey (thumper) wrote :

Hi Martin,

Can you suggest some of that UI goodness to smooth the process?

Changed in launchpad-bazaar:
assignee: nobody → beuno
importance: High → Undecided
status: Triaged → New
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Martin Albisetti (beuno) wrote :

So, this is interesting.
We have 2 separate actions, which are complementary: a merge request, and a review request.

The first question, for me is, does it make sense to want to request a review without the intention of merging it?

Revision history for this message
Aaron Bentley (abentley) wrote :

I think it does make sense to request a review without intending to merge. For example, I just asked you to perform a UI review before I had gotten the code ready for merging. I think the case where the code is *never* intended to merge is very rare.

Aaron Bentley (abentley)
Changed in launchpad-code:
status: Triaged → Incomplete
Revision history for this message
Aaron Bentley (abentley) wrote :

If this was really high-priority, it would be fixed by now.

Changed in launchpad-code:
importance: High → Low
Martin Albisetti (beuno)
Changed in launchpad-code:
assignee: Martin Albisetti (beuno) → nobody
Changed in launchpad:
status: Incomplete → Triaged
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.