Launchpad itself

Imported comment from Trac mangles hyperlink

Bug #296680 reported by Matthew Paul Thomas
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

1. Go to <http://launchpad.net/bugs/70653>.
2. In the second comment, click on "Debian bug 428500".

What happens: You go nowhere if you click on "Debian", and to an unrelated bug report if you click on "bug 428500".

What should happen: You go to http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=428500 regardless of which part of the phrase you click on.

Launchpad linking to an unrelated bug report is bug 505760. But this bug is separate from that: Launchpad is displaying Trac's raw wiki link code.

See original description
Matthew Paul Thomas (mpt)
description: updated
Revision history for this message
Graham Binns (gmb) wrote : Re: [Bug 296680] [NEW] Imported comment from Trac mangles hyperlink

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> I think this is a problem with Trac hyperlinks in general, not Debian
> bug links in particular.

The problem is the fact that although Trac allows people to use its
wiki syntax when commenting on a ticket, Launchpad doesn't get the
html-ified version of those comments. Instead, it gets the raw wiki
marked-up version and doesn't know what to do with it.

The options are as follows:

 * Launchpad could try to convert the comments to HTML when it imports them.
 * Launchpad could strip out the wiki markup when it imports the comments
 * The Trac LP plugin could be updated to return the HTML version of
the comments rather than the raw version.

 status triaged
 importance medium
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: http://getfiregpg.org

iEYEARECAAYFAkkZgVUACgkQwutMq02tGPoJ1wCfUPhpOQ3/R4boVBzApzn2kuhi
VToAmwT6AgBdvcjNhEEb81b7SSwWqT/O
=YABh
-----END PGP SIGNATURE-----

Changed in malone:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Björn Tillenius (bjornt) wrote :

On Tue, Nov 11, 2008 at 12:57:58PM -0000, Graham Binns wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
>
> > I think this is a problem with Trac hyperlinks in general, not Debian
> > bug links in particular.
>
> The problem is the fact that although Trac allows people to use its
> wiki syntax when commenting on a ticket, Launchpad doesn't get the
> html-ified version of those comments. Instead, it gets the raw wiki
> marked-up version and doesn't know what to do with it.
>
> The options are as follows:
>
> * Launchpad could try to convert the comments to HTML when it imports them.
> * Launchpad could strip out the wiki markup when it imports the comments
> * The Trac LP plugin could be updated to return the HTML version of
> the comments rather than the raw version.

I don't think the last one is a viable option. We shouldn't be inserting
raw HTML returned from a remote server.

Another option is not to make 'bug XXX' into links. Those don't make
much sense for imported comments (unless we map them to the bug tracker
from where we imported the comment).

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Not linking "bug X" in imported comments seems reasonable. Mapping it to the source bug tracker wouldn't have worked in this case anyway, because it was a link to a report in the Debian bug tracker rather than in the same Trac installation.

Curtis Hovey (sinzui)
Changed in launchpad:
importance: Medium → Low
tags: added: comments
Matthew Paul Thomas (mpt)
description: updated
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.