Soyuz-upload is too hairy
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Triaged
|
Low
|
Unassigned | ||
Bug Description
Andrew commented:
> * Finally, that this code is too complicated for a doctest. The doctest
> format is not well-suited to tests with this level of complexity. And test
> code this complex generally can't claim to be documentation either (if
> anything, you're documenting how the tests work, rather than the system that
> you're testing). You can, and should, be using unittest.TestCases for
> testing when that is appropriate. I think it is almost certainly
> appropriate here -- for instance, when I see multiple levels of indenting
> and asserts in a doctest, that's a very strong hint.
and
> As above: put it in a .py file, subclass unittest.TestCase, write test_foo
> methods. Doctests are a fine hammer, but not everything is a nail.
I can write this code, to simplify the soyuz-upload.txt test, as soon as I finished the soyuz deployment tests.
| Changed in launchpad-upload-and-queue: | |
| assignee: | nobody → cprov |
| status: | Unconfirmed → Confirmed |
| Vikram Dhillon (dhillon-v10) wrote | #1 |
| Michael Nelson (michael.nelson) wrote | #2 |
| Julian Edwards (julian-edwards) wrote | #3 |
| Changed in soyuz: | |
| assignee: | Celso Providelo (cprov) → nobody |
@ Celso Providelo: Any updates on this one, has this one already been fixed with the great UI 3.0 change.