Launchpad itself

bzr pull URL redirects to 'changes'

Bug #249924 reported by Robert Collins
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

Bazaar redirects to a 'changes' URL when pulling from a Launchpad http URL. For example,

/tmp$ bzr init branch
/tmp$ cd branch
/tmp/branch$ bzr pull http://bazaar.launchpad.net/~jelmer/bzr-svn/0.4
http://bazaar.launchpad.net/%7Ejelmer/bzr-svn/0.4 is permanently redirected to /~jelmer/bzr-svn/0.4/changes

Bazaar shouldn't redirect here. Instead it should pull the branch at http://bazaar.launchpad.net/~jelmer/bzr-svn.

Note that 'bzr branch http://bazaar.launchpad.net/~jelmer/bzr-svn' works.

See original description
Tags: lp-code
Revision history for this message
Jonathan Lange (jml) wrote :

Robert,

Can you please explain why you think this is a bug in Launchpad Bazaar rather than a bug in Bazaar?

jml

description: updated
Changed in launchpad-bazaar:
importance: Undecided → Medium
status: New → Incomplete
Revision history for this message
Andrew Bennetts (spiv) wrote :

When pulling and merging, the first thing bzr does is try to fetch the URL as a file, in case it is the URL to a merge directive (i.e. bundle). I think our loggerhead/apache configuration issues a redirect for a GET to bazaar.launchpad.net/~USER/PROJECT/BRANCH.

"bzr branch ..." doesn't have this issue because it doesn't do this check.

It's not immediately clear to me if the fault lies with bazaar.launchpad.net, the bzr client, or both.

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 249924] Re: bzr pull URL redirects to 'changes'

On Mon, 2008-07-21 at 00:57 +0000, Jonathan Lange wrote:
> Robert,
>
> Can you please explain why you think this is a bug in Launchpad Bazaar
> rather than a bug in Bazaar?

because bzr is perfect and love.

Or more sensibly, because bzr needs to make the request it makes, but
launchpad-bazaar has enough info to decide not to redirect to /changes
which is a purely browser specific resource.

(Also, redirecting to /changes is a bit ugly anyway).

-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

Revision history for this message
Tim Penhey (thumper) wrote :

On Tuesday 22 July 2008 11:05:47 Robert Collins wrote:
> On Mon, 2008-07-21 at 00:57 +0000, Jonathan Lange wrote:
> > Robert,
> >
> > Can you please explain why you think this is a bug in Launchpad Bazaar
> > rather than a bug in Bazaar?
>
> because bzr is perfect and love.
>
> Or more sensibly, because bzr needs to make the request it makes, but
> launchpad-bazaar has enough info to decide not to redirect to /changes
> which is a purely browser specific resource.
>
> (Also, redirecting to /changes is a bit ugly anyway).

Which really makes this a bug in loggerhead, as that is what is causing
the redirect.

Tim

Ghady Diab (ghady-diab)
Changed in launchpad-bazaar:
assignee: nobody → ghady-diab
assignee: ghady-diab → nobody
Revision history for this message
Jonathan Lange (jml) wrote :

OK, so this *is* a bug in our deployment. I don't know the right way to fix it though.

Changed in launchpad-bazaar:
importance: Medium → High
status: Incomplete → Triaged
Revision history for this message
Robert Collins (lifeless) wrote :

Taking 'high' off because we generally have folk use lp: urls and we now use bzr+ssh for all logged in users.

Changed in launchpad-code:
importance: High → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.