SQLObjectResultSet.__nonzero__() implementation does not strip result ordering.
Bug #246200 reported by
Celso Providelo
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Invalid
|
Undecided
|
Unassigned | ||
Storm |
Fix Released
|
Low
|
Jamu Kakar |
Bug Description
The current implementation of SelectResultSet
A lot of time is spent ordering the result set that will not affect the result of the operation, for instance bool(IArchive.
The original implementation of __nonzero__ in SQLObject does remove the ordering part correctly and this is the fastest alternative, it's faster then count(), any() or first();
Related branches
lp://staging/~jkakar/storm/is-empty-strips-order-by
- Kevin McDermott (community): Approve
- Robert Collins (community): Approve
- Storm Developers: Pending requested
-
Diff: 52 lines (+23/-1)2 files modifiedstorm/store.py (+1/-0)
tests/store/base.py (+22/-1)
tags: | added: tech-debt |
Changed in soyuz: | |
status: | New → Invalid |
Changed in storm: | |
milestone: | none → 0.17 |
assignee: | nobody → Jamu Kakar (jkakar) |
importance: | Undecided → Low |
status: | New → In Progress |
Changed in storm: | |
status: | In Progress → Fix Committed |
Changed in storm: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
See query #19 on OOPS-919EB43