SQLObjectResultSet.__nonzero__() implementation does not strip result ordering.

See query #19 on OOPS-919EB43

While that query is taking quite a while, it isn't clear that removing the ORDER BY would stop that page from timing out. There is a 19 second gap between statement #32 and the one where the TimeoutError was raised.

That should be investigated as well as fixing Storm to remove the ORDER BY clause.

Thanks for replying, James.

Yes, of course, there are other serious issues that needs to be sorted in order to eliminate the timeouts we are experiencing.

The initial report mentions the inefficient __nonzero__ implementation, specifically, because it surely has implications that go beyond that page.

We should definitely improve the SQLObjectResultSet.__nonzero__ implementation.

That said, if __nonzero__() returns True, do you go ahead and repeat the full query? If so, then it'd be better to restructure your page to just go ahead and do the query once and handle zero rows case appropriately.

There is no __nonzero__() in the native Storm ResultSet class as its use usually involves repeating queries for no good reason.

If the __nonzero__ is True we issue a similar query, but at that time its restricted to the package-search form (default) values.

We issue that query because it was supposed to be the simplest/quickest way to figure out when a PPA is inactive (zero source publications) and then easily modify the layout to avoid issues other empty or pointless queries. However, I admit it's a little cumbersome for active PPAs.