even when a project has an external bug tracker, bug references are always linkified within LP

Bug #235908 reported by Edwin Grubbs
22
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

In revision #2649 of this branch, the commit references "Bug#27430".
https://code.edge.launchpad.net/~mysql-developers/mysql/mysql-5.1

The bug reference is linkified pointing to https://code.launchpad.net/bugs/27430
However, it should really be referencing http://bugs.mysql.com/bug.php?id=27430

Support for MySQL's bugtracker is dependent on bug #74449. After that is done, it would be possible to have the text-to-html converter linkify "bug #NNN" to point to the project's bugtracker. Since MySQL's bugtracker already uses the "bug #NNN" syntax, it is not desirable to introduce a new syntax for externally referenced bugs.

A much less desirable alternative would be to turn off linkifying the "bug #NNN" text, which would avoid confusion, but it wouldn't provide added convenience.

Revision history for this message
Martin Pool (mbp) wrote :

So it seems to me this is not mysql-specific but rather a general issue that "bug #1234" in commit messages may refer to upstream bug numbers, not Launchpad bugs?

Revision history for this message
Elliot Murphy (statik) wrote :

Yes, it probably applies to many other projects. One idea is to store a format string that would be used to form the link to the bug tracker, probably in the same table that we store a link to the upstream bugtracker.

Revision history for this message
Björn Tillenius (bjornt) wrote : Re: [Bug 235908] Re: references to bugs.mysql.com are linkified pointing to LP bugs

On Fri, May 30, 2008 at 02:52:42AM -0000, Elliot Murphy wrote:
> Yes, it probably applies to many other projects. One idea is to store a
> format string that would be used to form the link to the bug tracker,
> probably in the same table that we store a link to the upstream
> bugtracker.

We kind of have this already in the code. Are you referring to something
that could be set manually, or simply a cache, so that you wouldn't have
to get the bug tracker from the db?

    subscribe

Revision history for this message
Elliot Murphy (statik) wrote : Re: references to bugs.mysql.com are linkified pointing to LP bugs

I was thinking of something that could be used by the text-to-html formatter, which currently has a hard coded format string. It makes sense that the bug watch code would already be storing a format string for the upstream tracker, so it's just a question of hooking that up to text-to-html.

Revision history for this message
Tim Penhey (thumper) wrote : Re: [Bug 235908] Re: references to bugs.mysql.com are linkified pointing to LP bugs

On Saturday 31 May 2008 02:19:38 Elliot Murphy wrote:
> I was thinking of something that could be used by the text-to-html
> formatter, which currently has a hard coded format string. It makes
> sense that the bug watch code would already be storing a format string
> for the upstream tracker, so it's just a question of hooking that up to
> text-to-html.

This is exactly what I was thinking too.

Something like an additional path to text-to-html to specify project
bug links or something.

Revision history for this message
Jonathan Lange (jml) wrote : Re: references to bugs.mysql.com are linkified pointing to LP bugs

This seems more like a Bugs issue than a Code issue.

Revision history for this message
Björn Tillenius (bjornt) wrote : Re: [Bug 235908] Re: references to bugs.mysql.com are linkified pointing to LP bugs

On Tue, Jul 08, 2008 at 08:02:31AM -0000, Jonathan Lange wrote:
> This seems more like a Bugs issue than a Code issue.
>
> ** Changed in: malone
> Product: Launchpad Bazaar Integration => Launchpad Bugs

Not really. To fix this you'd have to do something special when
rendering the commit messages, so I think the ultimate responsibility
lies on the Code team.

Revision history for this message
Jonathan Lange (jml) wrote : Re: references to bugs.mysql.com are linkified pointing to LP bugs

OK. Still probably a good thing to talk with Bugs about though :)

Changed in launchpad-bazaar:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Aaron Bentley (abentley) wrote :

I don't see why the Code team would need to do something special. We're using a standard formatter. If the project's bug settings indicate that they use a different tracker, that formatter could automatically link to that tracker.

Revision history for this message
Björn Tillenius (bjornt) wrote : Re: [Bug 235908] Re: references to bugs.mysql.com are linkified pointing to LP bugs

On Mon, Apr 26, 2010 at 08:12:31PM -0000, Aaron Bentley wrote:
> I don't see why the Code team would need to do something special. We're
> using a standard formatter. If the project's bug settings indicate that
> they use a different tracker, that formatter could automatically link to
> that tracker.

Well, you're using a standard formatter that has access only to a text
string. It doesn't know in which context it is.

You would have to either extend the existing one, or create a new one,
and pass in the project the bug ids should link to.

--
Björn Tillenius | https://launchpad.net/~bjornt

Revision history for this message
Robert Collins (lifeless) wrote : Re: references to bugs in commits are always linkified pointing to LP bugs

See also bug 712059 which is about the same issue in the context of federated bug comments.

description: updated
summary: - references to bugs.mysql.com are linkified pointing to LP bugs
+ references to bugs in commits are always linkified pointing to LP bugs
Changed in launchpad:
importance: Medium → High
Revision history for this message
Robert Collins (lifeless) wrote :

I'm going to rephrase this as 'even when a project has an external bug tracker, bug references are always linkified within LP.' This suggests a reasonable first approximation: use the tracker that most of the contexts use when linkifying bug text. For code there will always be one context, for bug comments there may be many (and we don't [currently] record the originating context, so we would inherit the bug context).

summary: - references to bugs in commits are always linkified pointing to LP bugs
+ even when a project has an external bug tracker, bug references are
+ always linkified within LP
tags: added: bugs code tales
removed: lp-code
Revision history for this message
Robert Collins (lifeless) wrote :

This would be nice to have but isn't a killer facility at the moment, would love patches (and be happy to mentor) - but dropping to low from a project perspective for now.

Changed in launchpad:
importance: High → Low
tags: added: bug-relationships
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.