Launchpad itself

git merge request does not show all commits that are being merged

Bug #1952739 reported by Dimitri John Ledkov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

https://code.launchpad.net/~xnox/ubuntu/+source/linux/+git/bionic/+merge/412577

Is a merge proposal of 16 patches.

Most of them are cherrypicks that got rebased recently.

Only the last 10 commits are shown, but the first 6 are missing, yet visible in the diff.

I was expecting 16 commits to be visible under "Unmerged commits" or some continuation/paging.

Revision history for this message
Jürgen Gmach (jugmac00) wrote :

Thank you for the bug report. The limit of 10 is hardcoded in the source code.

https://git.launchpad.net/launchpad/tree/lib/lp/code/model/branchmergeproposal.py#n995

I will talk with the team about whether there is a reason for this limit or whether we could lift it.

At very least there should be a message that the list of commits is limited.

Revision history for this message
Colin Watson (cjwatson) wrote :

Regardless of whether we lift it, it still can't be unboundedly large (for instance, imagine an MP that tries to merge the full history of a non-trivial branch into an entirely unrelated branch - this actually happens moderately often by accident), so we should still work out how to make the truncation clearer in the web UI.

Jürgen Gmach (jugmac00)
tags: added: lp-code
tags: added: code-review ui
Changed in launchpad:
status: New → Triaged
Jürgen Gmach (jugmac00)
Changed in launchpad:
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.