Duplicated code in translations upload forms

Bug #192925 reported by Jeroen T. Vermeulen
4
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

The methods POTemplateView.upload(), POFileUploadView.process_form(), and ProductSeriesView.translationsUpload() are suspiciously similar. The POTemplateView and ProductSeriesView ones really only differ in the arguments to addOrUpdateEntry/addOrUpdateEntriesFromTarball, and how a link to the import queue is generated.

The POFileUploadView one is similar, but adds the choice between published and user uploads, and does not support tarballs. A mixin could probably provide all three.

Changed in rosetta:
importance: Undecided → Low
Changed in rosetta:
status: New → Confirmed
description: updated
Curtis Hovey (sinzui)
tags: added: tech-debt
removed: cleanup
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.