DebBugs comment import doesn't handle invalid dates correctly.

Bug #185492 reported by Graham Binns
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

If the DebBugs comment import code encounters an invalid date when importing a comment it does not catch the error raised by Message.fromEmail() and instead allows it to propagate upwards.

DebBugs._importDebBugsComment() should catch these errors and handle them correctly.

Graham Binns (gmb)
Changed in malone:
status: New → Confirmed
Revision history for this message
Björn Tillenius (bjornt) wrote : Re: [Bug 185492] DebBugs comment import doesn't handle errors that it really ought to handle

On Wed, Jan 23, 2008 at 10:38:26PM -0000, Graham Binns wrote:
> Private bug reported:
>
> The latest run of the DebBugs comment import code on staging highlighted
> the fact that some errors which should be caught by the DebBugs code and
> logged as WARNINGS (rather than allowing them to propagate up the stack
> and become ERRORs with tracebacks) weren't being. A copy of the logfile
> for the import run is attached; the break down of the errors is as
> follows:
>
> * Invalid Date None - occurs 604 times.
> * Message exceeds size limit - occurs 34 times.
> * utf8 codec can't decode... - occurs 5 times.
> * Unknown encoding... - occurs 3 times.
> * UnknownSender (bad email address: robert$@debath.co.uk) - occurs once.

Catching these errors and convert them to warnings aren't always the
right thing to do. Better to file one bug for each error. We need to
handle each error differently. These are in fact errors, and we need to
change our code to cope with it.

Revision history for this message
Graham Binns (gmb) wrote :
description: updated
Revision history for this message
Graham Binns (gmb) wrote :

I've now split this bug up into four separate bugs:

 * This bug - Invalid dates aren't handled.
 * Bug #185609 - Oversized messages aren't handled.
 * Bug #185613 - Encoding errors aren't handled.
 * Bug #185620 - Invalid senders aren't handled.

Curtis Hovey (sinzui)
visibility: private → public
Curtis Hovey (sinzui)
Changed in malone:
status: Confirmed → Triaged
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.