Launchpad itself

Please add an activereviews view to the repository level

Bug #1755259 reported by Nish Aravamudan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
High
Unassigned

Bug Description

Similar to the per-branch view, it would be very helpful to see all pending reviews for an entire repository.

Related branches

~pappacena/launchpad:gitrepo-pending-merges-tuning
Launchpad code reviewers: Pending requested
Diff: 363 lines (+191/-28)
4 files modified
lib/lp/code/browser/branchmergeproposal.py (+64/-18)
lib/lp/code/browser/gitrepository.py (+64/-5)
lib/lp/code/browser/tests/test_gitrepository.py (+62/-4)
lib/lp/code/templates/branchmergeproposal-summary-fragment.pt (+1/-1)
Colin Watson (cjwatson)
tags: added: code-review git lp-code
Changed in launchpad:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Thiago F. Pappacena (pappacena) wrote :

- The project page, when you click on "code", has a link to the activereviews page of the project (on https://code.launchpad.net/launchpad, search for "Launchpad itself has XX active reviews."

- The repository page doesn't have a link visible in production today (see https://code.launchpad.net/~pappacena/launchpad/+git/launchpad), but if we set the feature flag "code.git.show_repository_mps" to True, we can see a summary of proposed merges and, at the top of this area, a link to the +activereviews page.

Is there a reason to have the code.git.show_repository_mps flag disabled in production? Wouldn't it be useful to just turn that on and see both the link to activepages *and* the summary of MPs?

Maybe cjwatson has some opinion on that.

Revision history for this message
Thiago F. Pappacena (pappacena) wrote :
Revision history for this message
Colin Watson (cjwatson) wrote :

Ah - it looks like we missed that this bug is a duplicate of bug 1789847.

The feature flag was added to mitigate performance problems; see bug 1790047. We'll need to fix those before being able to turn the feature flag on.

(FWIW, I found this by doing "tig blame" on the template; the bug is referenced from the commit that added the feature flag.)

Revision history for this message
Thiago F. Pappacena (pappacena) wrote :

Thanks for the help! I'll check that bug and see what can be improved in terms of performance there.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.