Git merge proposals can select wrong repository

Bug #1604831 reported by Joel Sing
34
This bug affects 7 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

When creating a git merge proposal, the target repository is picked (often other, since it is not in the list) - at this point, if an invalid value is entered (e.g. an incorrect reviewer) and the 'Propose merge' button is clicked, the page is redisplayed with an "Invalid value" error.

However at this point the target repository reverts to the first one listed. This is also not obvious since the page scrolls back down to where the invalid value is. The selected repository should remain selected.

It would also be ideal if Launchpad went "are you crazy?" when the target for the proposal is completely unrelated to the repository - while this is probably difficult, it would prevent the above bug from creating crazy proposals...

Revision history for this message
Nick Moffitt (nick-moffitt) wrote :

I just had an outage-fixing firewall change delay in confusion as a result of this.

Colin Watson (cjwatson)
tags: added: code-review confusing-ui git lp-code ui
Changed in launchpad:
status: New → Triaged
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.