inline diff comments don't survive being superseded
Bug #1334575 reported by
Nick Moffitt
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Triaged
|
High
|
Unassigned | ||
Bug Description
If you re-post a merge proposal so that it supersedes another, it will carry along the original comments with styling to indicate that they came from the original proposal. Unfortunately, this does not extend to inline diff comments. This can lead to confusion as parts of the conversation will be missing.
Now I understand that it's difficult to do when the diff changes, but surely that can happen to an existing MP, can't it? There must already be code to handle what happens to a diff comment when its corresponding hunk vanishes or updates. Can that be applied to the new MP?
Revision history for this message
| William Grant (wgrant) wrote | #1 |
| Changed in launchpad: | |
| importance: | Undecided → High |
| status: | New → Triaged |
| tags: | added: code-import inline-comments |
Revision history for this message
| Tom Haddon (mthaddon) wrote | #2 |
| tags: |
added: code-review removed: code-import |
To post a comment you must log in.
Within an MP you can currently only see old comments by using the diff selector dropdown. We're investigating approaches to pulling them forward onto newer diffs.
However, I'm interested in your application for superseding merge proposals. That functionality's really only designed to be used when something fundamental like the target branch has changed. What's your use case?