Merge proposal "needs review" emails can be sent before the diff is generated
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Triaged
|
High
|
Unassigned |
Bug Description
Setting an MP to Needs Review creates an UpdatePreviewDi
I'm not quite sure how to fix this. Possibly the MPNREJ should be created SUSPENDED. The UPDJ can then unsuspend it when it completes. But if the UPDJ fails we still need to unsuspend the MPNREJ, possibly via a celerybeat task that just unsuspends any MPNREJ over a certain age.