Launchpad itself

Scanning of branches with linked private bugs is broken

Bug #1040777 reported by Manuel de la Peña
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Steve Kowalik

Bug Description

If a branch is pushed with linked bugs via de command line parameter of bzr --fixes the scanning of the branch gets stuck. To test it simply do something of the type:

bzr commit -m"Fixes super bug." --fixes lp:123223

This also happens when you do a commit with --unchanged (might be of some useful info)

bzr commit -m"Link bugs." --unchanged --fixes lp:121212

There are at least 3 branches blocked due to this issue:

lp:~ralsina/ubuntuone-client/use-new-fsevents-api-2
lp:~mandel/ubuntuone-client/correct-fsevents
lp:~mandel/ubuntuone-client/use-new-fsevents-api

These might be useful for debugging so they won't be deleted unless we are allowed.

Related branches

lp://staging/~wgrant/launchpad/security.cfg-cowboys (Merged)
lp://staging/~stevenk/launchpad/branch-scanner-private-bugs
William Grant (community): Approve (code)
Diff: 35 lines (+18/-0)
1 file modified
lib/lp/code/model/tests/test_branchjob.py (+18/-0)
Revision history for this message
Colin Watson (cjwatson) wrote :

These are all essentially the same OOPS, exemplified by:

  https://oops.canonical.com/?oopsid=OOPS-43dbe2da91e0238891cba01fef847c4c

Revision history for this message
William Grant (wgrant) wrote :

OOPS-0a4bfabe3a504d870fdbc9c08eb61ce1 is from qastaging with the crashy lock patched out -- it's trying to add a bugnotification for a private bug, but the branchscanner user isn't allowed to read the access control tables.

summary: - Scanning of branches with linked bugs is broken
+ Scanning of branches with linked private bugs is broken
Revision history for this message
William Grant (wgrant) wrote :

Because it's using BugTaskFlat, the only table it absolutely needs access to is AccessPolicyGrant. That's enough to fix it locally.

William Grant (wgrant)
Changed in launchpad:
importance: Undecided → Critical
status: New → Triaged
tags: added: branch-scanner bug-branch-links email fallout oops regression
Revision history for this message
William Grant (wgrant) wrote :

We've applied a workaround to production, so this is "fixed" now.

GRANT SELECT ON accesspolicygrant TO branchscanner;

tags: added: disclosure sharing
Changed in launchpad:
assignee: nobody → Steve Kowalik (stevenk)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r15862 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15862) is part of this bug's fix.

tags: added: qa-needstesting
Changed in launchpad:
status: Triaged → In Progress
William Grant (wgrant)
tags: added: qa-untestable
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r15866 (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15866) by a commit, but not testable.

Changed in launchpad:
status: In Progress → Fix Committed
Steve Kowalik (stevenk)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.