No output for package activity that has already been performed

Bug #928933 reported by Andreas Hasenack
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Landscape Client
Fix Committed
Medium
Dave Jones

Bug Description

Check out this activity on staging:
https://staging.landscape.canonical.com/account/landscape-devel/computer/1705/activity/134312

It's a package activity that required an approval. I approved it, but there is no output (click on "succeeded": you only get the approval time).

The reason for this is that the changes the activity would performed had already been performed by other activities. This can be reproduced by requesting a package to be installed in the Landscape UI and then manually installing it on the server, before the activity has been performed.

Client is 11.11~bzr450-0ubuntu0~lucid1

description: updated
Revision history for this message
Björn Tillenius (bjornt) wrote :

I don't think this has anything to do with activities requiring approval. Looking at bug 928941, it seems that at the time when you approved the activity, wget had already been upgraded, and the the other two packages had already been removed. So we need handle the case where some of the changes have already been applied.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

If that's the case, then I think we can leave it be, because it's not a new behavior. I remember this being so before.

Revision history for this message
Björn Tillenius (bjornt) wrote :

I confirmed that this happens when the client handles an activity where all the changes have already been performed by other activities or manually.

I guess simply returning a message saying that no changes needed to be done would be good to start with. Later we should check each action to see whether it needs to be executed or not.

summary: - No output for package activity that needed approval
+ No output for package activity that has already been performed
description: updated
tags: added: low-hanging-fruit
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

This bug has not seen any activity in the last 6 months, so it is being automatically closed.

If you are still experiencing this issue, please feel free to re-open.

Landscape Team

Changed in landscape-client:
status: New → Invalid
Changed in landscape-client:
status: Invalid → Triaged
Revision history for this message
Dave Jones (waveform) wrote :
Changed in landscape-client:
assignee: nobody → Dave Jones (waveform)
status: Triaged → In Progress
Dave Jones (waveform)
Changed in landscape-client:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.