The ExchangeHelper provides more than it should

Bug #499016 reported by Free Ekanayaka
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Landscape Client
Fix Released
Low
Free Ekanayaka

Bug Description

The current ExchangeHelper implementation provides to the tests a full
broker service, rather than just a testable MessageExchange.

This makes a the test suites for the landscape.broker.exchange and the
landscape.broker.registration modules depend on extra components (the
BrokerService) which the components under test don't depend on. As part
of the AMP migration task we need to decouple the ExchangeHelper from
the BrokerService, which in turn eventually depends on DBus.

 affects landscape-client
 status inprogress
 importance medium
 assignee free.ekanayaka
 milestone 1.4.3

Changed in landscape-client:
importance: Medium → Low
tags: added: fix-it-friday review
tags: added: amp-migration
Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

As suggested by Jamu, I created an special branch for the AMP migration:

lp:~landscape/landscape-client/amp-trunk

this and the following AMP-related branches will be based on it.

Revision history for this message
Thomas Herve (therve) wrote :

Huuu lots of changes my head hurts :) But it looks good, +1.

Revision history for this message
Kevin McDermott (bigkevmcd) wrote :

Looks good to me, +1

tags: removed: review
Changed in landscape-client:
status: In Progress → Fix Committed
tags: added: needs-testing
tags: removed: needs-testing
Changed in landscape-client:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.