sysinfo disk plugin prints unnecessary warnings about the / device when over capacity

Bug #260230 reported by Christopher Armstrong
12
Affects Status Importance Assigned to Milestone
Landscape Client
Fix Released
Medium
Christopher Armstrong
Landscape Server
Fix Released
Critical
Christopher Armstrong
landscape-client (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

- / is mounted as both a rootfs and the usual ext3 these days, so if / is over capacity, two notes about it will be printed.

- the / device is *also* mounted at /dev/.static/dev (kinda), and we print a note about this if the / device is over capacity, but that's pretty lame.

Changed in landscape:
assignee: nobody → radix
milestone: none → thames-pre-7
Changed in landscape-client:
assignee: nobody → radix
Revision history for this message
Christopher Armstrong (radix) wrote :

Ok, this is up for review in the attached branch.

It does three things:
Ignore duplicate mount points;
Ignore duplicate mount devices;
Ignore gvfs filesystems, because they just reflect the size of /.

description: updated
Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

Very awesome! +1!

Changed in landscape:
status: New → In Progress
Changed in landscape-client:
status: New → In Progress
Revision history for this message
Jamu Kakar (jkakar) wrote :

Nice, +1!

Revision history for this message
Christopher Armstrong (radix) wrote :

Merged to trunk, thanks.

Changed in landscape:
importance: Undecided → Medium
status: In Progress → Fix Committed
Changed in landscape-client:
importance: Undecided → Medium
status: In Progress → Fix Committed
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

This was released into production.

Changed in landscape-client:
status: Fix Committed → Fix Released
Changed in landscape:
status: Fix Committed → Fix Released
Changed in landscape:
importance: Medium → Critical
milestone: thames-pre-7 → thames-pre-8
status: Fix Released → Fix Committed
Revision history for this message
Christopher Armstrong (radix) wrote :

Ok, marking this for thames-pre-8 and moving back to Fix Committed, because not all the revisions of this branch were really merged, even though they were reviewed. They have now been merged to trunk.

Changed in landscape-client:
status: Fix Released → Fix Committed
Revision history for this message
Christopher Armstrong (radix) wrote :

never mind, this didn't make it in time for pre-8. It'll still make it into intrepid, though

Changed in landscape:
milestone: thames-pre-8 → thames-pre-9
Revision history for this message
Christopher Armstrong (radix) wrote :

Ok, I've attached a branch for a new release of landscape-client 1.0.21.2. The tarball has been uploaded to launchpad, and this branch contains the changes to source and to debian/changelog. The only change to source from the previous version is the one from the other branch in this ticket.

Requesting sponsorship.

Revision history for this message
Christopher Armstrong (radix) wrote :

Bug #277658 supercedes this as far as package updating goes; please look at the branch in that ticket.

Changed in landscape-client:
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package landscape-client - 1.0.23-0ubuntu0.8.10

---------------
landscape-client (1.0.23-0ubuntu0.8.10) intrepid; urgency=low

  * New upstream release. (LP: #277658):
    Changes since 1.0.21.1:
    - Don't print duplicate warnings when / is nearing capacity in sysinfo
      (LP: #260230).
    - Slight change to link text in landscape-sysinfo.
    - Don't crash badly when programs are run as the incorrect user
      (LP: #268879).
  * debian/changelog: New debian-version scheme including Ubuntu version. The
    same upstream version is available for all supported releases.
    (LP: #277682).
  * debian/landscape-client.postrm: Delete log and data files upon purge
    (LP: #121182).
  * debian/landscape-common.postrm: Delete the sysinfo logs upon purge.

 -- Christopher Armstrong <email address hidden> Thu, 09 Oct 2008 11:40:51 -0400

Changed in landscape-client:
status: In Progress → Fix Released
Changed in landscape-client:
status: Fix Committed → Fix Released
Changed in landscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.