'Invalid account name or registration key' error, when reached max of 20 computers pending approval, should be clearer
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Landscape Client |
Fix Committed
|
Undecided
|
Unassigned | ||
Landscape Server |
Fix Released
|
Low
|
Alberto Donato | ||
landscape-client (Ubuntu) |
Fix Released
|
Undecided
|
Andreas Hasenack |
Bug Description
Trying to register a computer in Landscape when there are already 20 computers pending approval results in the error message:
Request a new registration for this computer now? (Y/n): Please wait... Invalid account name or registration key.
This message should be made clearer to something like "Max limit of computers pending approval reached" or something along these lines.
Tested on Landscape On-Premises 16.06 on Trusty with a Trusty client running landscape-client 14.12-0ubuntu0.
Steps to reproduce:
-------------------
Run landscape-config 20 times on the same computer to reach 20 computers pending approval in Landscape. Once 20 requests are reached, the next one will fail with that error message.
Related branches
- Chad Smith: Approve
- 🤖 Landscape Builder: Approve (test results)
- Free Ekanayaka (community): Approve
-
Diff: 608 lines (+194/-83)6 files modifieddebian/changelog (+6/-0)
landscape/__init__.py (+10/-9)
landscape/broker/registration.py (+10/-9)
landscape/broker/tests/test_registration.py (+61/-12)
landscape/configuration.py (+45/-33)
landscape/tests/test_configuration.py (+62/-20)
summary: |
- 'Invalid account name or registration key' error when reached max of 20 - computers pending approval + 'Invalid account name or registration key' error, when reached max of 20 + computers pending approval, should be clearer |
Changed in landscape: | |
assignee: | nobody → Alberto Donato (ack) |
Changed in landscape: | |
status: | Triaged → In Progress |
Changed in landscape: | |
milestone: | none → 17.02 |
status: | In Progress → Fix Committed |
Changed in landscape: | |
status: | Fix Committed → Fix Released |
information type: | Proprietary → Public |
Changed in landscape-client: | |
status: | New → Fix Committed |
Changed in landscape-client (Ubuntu): | |
assignee: | nobody → Andreas Hasenack (ahasenack) |
status: | New → In Progress |
Agreed, this is "as designed". But, the error message could indeed be clearer.