landscape-config new registration request prompt should default to no for subsequent runs
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Landscape Client |
Fix Committed
|
Low
|
Alberto Donato | ||
| landscape-client (Ubuntu) |
Fix Released
|
Low
|
Andreas Hasenack | ||
| Trusty |
Fix Released
|
Low
|
Andreas Hasenack | ||
| Xenial |
Fix Released
|
Low
|
Andreas Hasenack | ||
| Zesty |
Fix Released
|
Low
|
Andreas Hasenack | ||
| Artful |
Fix Released
|
Low
|
Andreas Hasenack | ||
Bug Description
[Impact]
When running landscape-config, this prompt always defaults to Yes:
"Request a new registration for this computer now? (Y/n):"
The landscape-config command can be used to change configuration options in /etc/landscape/
[Test Case]
1) Install landscape-client package on computer.
2) Run landscape-config to register client for the first time. Note how the default answer for the registration question is "Y"
3) Run landscape-config again to change an option:
sudo landscape-config --ping-interval=60
4) Verify that the question about requesting a new registration defaults to "N" this time.
[Regression Potential]
Admins and scripts who relied on the old behavior might be surprised that a new registration is not requested anymore by default if the client is already registered, but I believe it's a welcomed change. It was even a sort of known issue in our FAQ (https:/
"""
/!\ Very important: when using this method [Ed: calling landscape-config], you MUST NOT request a new registration for the computer, as that will create a duplicate machine in your Landscape account!
"""
If there is a regression here, it will just affect the default answer given to the "do you wanted to register" question. The admin can still answer however he/she wishes.
[Other Info]
* Upstream revision:
http://
This PPA has test packages built from these branches, using a ~ppaN suffix:
https:/
--- Original description ---
When running landscape-config, this prompt always defaults to Yes:
"Request a new registration for this computer now? (Y/n):"
The landscape-config command can be used to change configuration options in /etc/landscape/
Steps to replicate:
1) Install landscape-client package on computer
$ sudo apt-get install landscape-client
2) Run landscape-config to register client for the first time
$ sudo landscape-config --account-name standalone --url https://<server>
3) Run landscape-config again to change an option
$ sudo landscape-config --ping-interval=60
[Test Case]
When running landscape-config, this prompt always defaults to Yes:
"Request a new registration for this computer now? (Y/n):"
The landscape-config command can be used to change configuration options in /etc/landscape/
To reproduce:
1) Install landscape-client package on computer.
2) Run landscape-config to register client for the first time.
3) Run landscape-config again to change an option:
sudo landscape-config --ping-interval=60
Related branches
- Free Ekanayaka (community): Approve
- 🤖 Landscape Builder: Approve (test results)
- Eric Snow (community): Approve
-
Diff: 102 lines (+43/-4)2 files modifiedlandscape/configuration.py (+12/-1)
landscape/tests/test_configuration.py (+31/-3)
| Changed in landscape: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| tags: | added: bug-squad kanban |
| Changed in landscape: | |
| assignee: | nobody → Simon Poirier (simpoir) |
| Changed in landscape: | |
| status: | Triaged → In Progress |
| David Coronel (davecore) wrote | #1 |
| Changed in landscape: | |
| assignee: | Simon Poirier (simpoir) → nobody |
| status: | In Progress → Confirmed |
| status: | Confirmed → Triaged |
| Changed in landscape: | |
| assignee: | nobody → Alberto Donato (ack) |
| status: | Triaged → In Progress |
| Changed in landscape: | |
| status: | In Progress → Fix Committed |
| description: | updated |
| information type: | Proprietary → Public |
| affects: | landscape → landscape-client |
| Changed in landscape-client (Ubuntu): | |
| status: | New → In Progress |
| assignee: | nobody → Andreas Hasenack (ahasenack) |
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in landscape-client (Ubuntu): | |
| status: | In Progress → Fix Released |
| description: | updated |
| description: | updated |
| description: | updated |
| description: | updated |
| description: | updated |
| description: | updated |
| description: | updated |
| Changed in landscape-client (Ubuntu Trusty): | |
| status: | New → In Progress |
| Changed in landscape-client (Ubuntu Xenial): | |
| status: | New → In Progress |
| Changed in landscape-client (Ubuntu Zesty): | |
| status: | New → In Progress |
| Changed in landscape-client (Ubuntu Artful): | |
| status: | New → In Progress |
| Changed in landscape-client (Ubuntu Trusty): | |
| assignee: | nobody → Andreas Hasenack (ahasenack) |
| Changed in landscape-client (Ubuntu Xenial): | |
| assignee: | nobody → Andreas Hasenack (ahasenack) |
| Changed in landscape-client (Ubuntu Zesty): | |
| assignee: | nobody → Andreas Hasenack (ahasenack) |
| Changed in landscape-client (Ubuntu Artful): | |
| assignee: | nobody → Andreas Hasenack (ahasenack) |
| Łukasz Zemczak (sil2100) wrote Please test proposed package | #3 |
| Changed in landscape-client (Ubuntu Artful): | |
| status: | In Progress → Fix Committed |
| tags: | added: verification-needed verification-needed-artful |
| Łukasz Zemczak (sil2100) wrote | #4 |
| Changed in landscape-client (Ubuntu Zesty): | |
| status: | In Progress → Fix Committed |
| tags: | added: verification-needed-zesty |
| Łukasz Zemczak (sil2100) wrote | #5 |
| Changed in landscape-client (Ubuntu Xenial): | |
| status: | In Progress → Fix Committed |
| tags: | added: verification-needed-xenial |
| Łukasz Zemczak (sil2100) wrote | #6 |
| Changed in landscape-client (Ubuntu Trusty): | |
| status: | In Progress → Fix Committed |
| tags: | added: verification-needed-trusty |
| David Coronel (davecore) wrote | #7 |
| Changed in landscape-client (Ubuntu): | |
| importance: | Undecided → Low |
| Changed in landscape-client (Ubuntu Trusty): | |
| importance: | Undecided → Low |
| Changed in landscape-client (Ubuntu Xenial): | |
| importance: | Undecided → Low |
| Changed in landscape-client (Ubuntu Zesty): | |
| importance: | Undecided → Low |
| Changed in landscape-client (Ubuntu Artful): | |
| importance: | Undecided → Low |
| tags: |
added: verification-done-artful verification-done-trusty verification-done-xenial verification-done-zesty removed: verification-needed-artful verification-needed-trusty verification-needed-xenial verification-needed-zesty |
| Launchpad Janitor (janitor) wrote | #8 |
| Changed in landscape-client (Ubuntu Artful): | |
| status: | Fix Committed → Fix Released |
| Łukasz Zemczak (sil2100) wrote Update Released | #9 |
| Launchpad Janitor (janitor) wrote | #10 |
| Changed in landscape-client (Ubuntu Zesty): | |
| status: | Fix Committed → Fix Released |
| Launchpad Janitor (janitor) wrote | #11 |
| Changed in landscape-client (Ubuntu Xenial): | |
| status: | Fix Committed → Fix Released |
| Launchpad Janitor (janitor) wrote | #12 |
| Changed in landscape-client (Ubuntu Trusty): | |
| status: | Fix Committed → Fix Released |
Should this be moved to landscape-client?