kuryr

/NetworkDriver.CreateEndpoint should handle for the empty Interfaces in the request

Bug #1499779 reported by Taku Fukushima
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kuryr
Fix Committed
Undecided
Taku Fukushima

Bug Description

The current /NetworkDriver.CreateEndpiont doesn't handle the case libnetwork gives the empty Interfaces property in the request and it's failed when it receives the request which has the empty Interfaces property. However, with the libnetwork CLI in Docker 1.8.0, we can't specify the Interfaces property and it's always empty. So Kuryr should put a new entry with the ID 0 and the generated random MAC address.

Taku Fukushima (tfukushima)
Changed in kuryr:
assignee: nobody → Taku Fukushima (tfukushima)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kuryr (master)

Fix proposed to branch: master
Review: https://review.openstack.org/227961

Changed in kuryr:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kuryr (master)

Reviewed: https://review.openstack.org/227961
Committed: https://git.openstack.org/cgit/openstack/kuryr/commit/?id=c2a1464c91cd1fccb8d25e225bc7d86eaf3f4f2b
Submitter: Jenkins
Branch: master

commit c2a1464c91cd1fccb8d25e225bc7d86eaf3f4f2b
Author: Taku Fukushima <email address hidden>
Date: Sat Sep 26 01:02:49 2015 +0900

    Fix /NetworkDriver.CreateEndpoint to handle the empty Interfaces

    The current /NetworkDriver.CreateEndpiont doesn't handle the case
    libnetwork gives the empty Interfaces property in the request and it's
    failed when it receives the request which has the empty Interfaces
    property. However, with the libnetwork CLI in Docker 1.8.0 we can't
    specify the Interfaces property and it's always empty.

    This patch makes Kuryr put a new entry with the ID 0 if it receives the
    empty interface dictionary in the requests. MacAddress and Address or
    AddressIPv6 are filled by allocated ones.

    Change-Id: I689d2f3aa8c5d047dbdcfee425910951530fb621
    Signed-off-by: Taku Fukushima <email address hidden>
    Closes-Bug: #1499779

Changed in kuryr:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on kuryr (master)

Change abandoned by Mohammad Banikazemi (<email address hidden>) on branch: master
Review: https://review.openstack.org/228214
Reason: Fixed elsewhere.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.