kolla-toolbox can't build on offline platform

Bug #2020761 reported by Gaël THEROND
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Status tracked in Bobcat
Antelope
Fix Committed
Medium
Unassigned
Bobcat
Fix Released
Medium
Gaël THEROND
Xena
Fix Released
Medium
Unassigned
Yoga
Fix Committed
Medium
Unassigned
Zed
Fix Committed
Medium
Unassigned

Bug Description

When building kolla containers from a platform that only use internal repository and mirror to retrieve artifacts, the current kolla-toolbox structure doesn't work as it retrieve packages straight from the upstream ansible-galaxy.

Offline platform would require to either be able to point to an internal galaxy mirror, or to use local tar.gz archive directly.

The best way to achieve that is to mimic what we already do for prometheus exporter.

So this patch should introduce the following:

1°/- Put the ansible-galaxy call in a kolla_toolbox_collections_install control block.
2°/- Introduce a new list variable called kolla_toolbox_collections = [].
3°/- Introduce two new ARG such as <collection_name>_collection_version=<version> and <collection_name>_collection_url=<url>

Doing that allows us to keep both upstream + offline usage.

Gaël THEROND (fl1nt)
Changed in kolla:
assignee: nobody → Gaël THEROND (fl1nt)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/kolla/+/884368

Changed in kolla:
status: New → In Progress
Revision history for this message
Gaël THEROND (fl1nt) wrote :

So the plan slightly changed as adding those variable for all packages would have been a pain to support, you can now easily override package list and version as well as origin URL from the archives retrieval through the usual template-overrides.j2 mecanism.

Changed in kolla:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.opendev.org/c/openstack/kolla/+/884368
Committed: https://opendev.org/openstack/kolla/commit/7f38e1df71eafb250b14c4e125c7313bd9218f7d
Submitter: "Zuul (22348)"
Branch: master

commit 7f38e1df71eafb250b14c4e125c7313bd9218f7d
Author: Gaël THEROND (Fl1nt) <email address hidden>
Date: Thu May 25 16:39:25 2023 +0200

    Improve kolla-toolbox offline support.

      * Use structure that allow for custom package version and base URL.

    Change-Id: I169e51c0f5c691518ada1837990b5bdd2a3d1481
    Closes-bug: #2020761

Changed in kolla:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/kolla/+/893849

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/kolla/+/893851

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/kolla/+/893852

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/kolla/+/893854

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on kolla (stable/xena)

Change abandoned by "Michal Nasiadka <email address hidden>" on branch: stable/xena
Review: https://review.opendev.org/c/openstack/kolla/+/893854
Reason: xena going EOL

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/kolla/+/893854
Committed: https://opendev.org/openstack/kolla/commit/4835a3d607b67259f85599114ca98d4afd35b5a8
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 4835a3d607b67259f85599114ca98d4afd35b5a8
Author: Gaël THEROND (Fl1nt) <email address hidden>
Date: Thu May 25 16:39:25 2023 +0200

    Improve kolla-toolbox offline support.

      * Use structure that allow for custom package version and base URL.

    Change-Id: I169e51c0f5c691518ada1837990b5bdd2a3d1481
    Closes-bug: #2020761
    (cherry picked from commit 7f38e1df71eafb250b14c4e125c7313bd9218f7d)
    (cherry picked from commit 8558004ab70919cc2a822107c953a24710227f9e)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/kolla/+/893851
Committed: https://opendev.org/openstack/kolla/commit/8558004ab70919cc2a822107c953a24710227f9e
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 8558004ab70919cc2a822107c953a24710227f9e
Author: Gaël THEROND (Fl1nt) <email address hidden>
Date: Thu May 25 16:39:25 2023 +0200

    Improve kolla-toolbox offline support.

      * Use structure that allow for custom package version and base URL.

    Change-Id: I169e51c0f5c691518ada1837990b5bdd2a3d1481
    Closes-bug: #2020761
    (cherry picked from commit 7f38e1df71eafb250b14c4e125c7313bd9218f7d)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/kolla/+/893852
Committed: https://opendev.org/openstack/kolla/commit/0cdce9f7763cbdd6ec54f975a2113d9122f5e8fb
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 0cdce9f7763cbdd6ec54f975a2113d9122f5e8fb
Author: Gaël THEROND (Fl1nt) <email address hidden>
Date: Thu May 25 16:39:25 2023 +0200

    Improve kolla-toolbox offline support.

      * Use structure that allow for custom package version and base URL.

    Change-Id: I169e51c0f5c691518ada1837990b5bdd2a3d1481
    Closes-bug: #2020761
    (cherry picked from commit 7f38e1df71eafb250b14c4e125c7313bd9218f7d)
    (cherry picked from commit 8558004ab70919cc2a822107c953a24710227f9e)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/kolla/+/893849
Committed: https://opendev.org/openstack/kolla/commit/47e3d894a4d2ab3c139e6d9bee664801daa780f3
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 47e3d894a4d2ab3c139e6d9bee664801daa780f3
Author: Gaël THEROND (Fl1nt) <email address hidden>
Date: Thu May 25 16:39:25 2023 +0200

    Improve kolla-toolbox offline support.

      * Use structure that allow for custom package version and base URL.

    Change-Id: I169e51c0f5c691518ada1837990b5bdd2a3d1481
    Closes-bug: #2020761
    (cherry picked from commit 7f38e1df71eafb250b14c4e125c7313bd9218f7d)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla xena-eol

This issue was fixed in the openstack/kolla xena-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.