kolla-ansible

Baremetal role should not reference service groups

Series stein
Bug #1841073

Bug #1841073 reported by Mark Goddard on 2019-08-22

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
kolla-ansible	Fix Released	Medium	Mark Goddard	kolla-ansible 9.0.0 "Train"
Stein	Fix Committed	Medium	Mark Goddard	kolla-ansible 8.0.1
Train	Fix Released	Medium	Mark Goddard	kolla-ansible 9.0.0 "Train"

Bug Description

The baremetal role does not currently assume too much about the inventory, and in kayobe the seed is deployed using a very minimal inventory.

Icf3f01516185afb7b9f642407b06a0204c36ecbe added a reference to the etcd group in the baremetal role, which causes kayobe seed deployment to failwith the following error:

AnsibleUndefinedVariable: 'dict object' has no attribute 'etcd'

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-08-22: Fix proposed to kolla-ansible (master)

Fix proposed to branch: master
Review: https://review.opendev.org/678047

Changed in kolla-ansible:
assignee:	nobody → Mark Goddard (mgoddard)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-08-22: Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/678047
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=331d373b996d9e7b7f9e6d9a1fa48821ddf1d62b
Submitter: Zuul
Branch: master

commit 331d373b996d9e7b7f9e6d9a1fa48821ddf1d62b
Author: Mark Goddard <email address hidden>
Date: Thu Aug 22 16:30:56 2019 +0100

Don't assume etcd group exists in baremetal role

    The baremetal role does not currently assume too much about the
    inventory, and in kayobe the seed is deployed using a very minimal
    inventory.

    Icf3f01516185afb7b9f642407b06a0204c36ecbe added a reference to the etcd
    group in the baremetal role, which causes kayobe seed deployment to fail
    with the following error:

AnsibleUndefinedVariable: 'dict object' has no attribute 'etcd'

This change defaults the group lookup to an empty list.

Change-Id: Ib3252143a97652c5cf70b56cbfd7c7ce69f93a55
Closes-Bug: #1841073

Changed in kolla-ansible:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-08-22: Fix proposed to kolla-ansible (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/678082

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-08-22: Fix merged to kolla-ansible (stable/stein)

Reviewed: https://review.opendev.org/678082
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=86eb21dd988b180d2dcbcc1c823c8c7c18672b59
Submitter: Zuul
Branch: stable/stein

commit 86eb21dd988b180d2dcbcc1c823c8c7c18672b59
Author: Mark Goddard <email address hidden>
Date: Thu Aug 22 16:30:56 2019 +0100

Don't assume etcd group exists in baremetal role

    The baremetal role does not currently assume too much about the
    inventory, and in kayobe the seed is deployed using a very minimal
    inventory.

    Icf3f01516185afb7b9f642407b06a0204c36ecbe added a reference to the etcd
    group in the baremetal role, which causes kayobe seed deployment to fail
    with the following error:

AnsibleUndefinedVariable: 'dict object' has no attribute 'etcd'

This change defaults the group lookup to an empty list.

    Change-Id: Ib3252143a97652c5cf70b56cbfd7c7ce69f93a55
    Closes-Bug: #1841073
    (cherry picked from commit 331d373b996d9e7b7f9e6d9a1fa48821ddf1d62b)