In Ansible 2.3, when statement should not contain delimiters

Bug #1695142 reported by Duong Ha-Quang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
Medium
Duong Ha-Quang
Ocata
Fix Released
Undecided
Unassigned
Pike
Fix Released
Undecided
Unassigned

Bug Description

When run precheck action, there are many warning is spitted out:

TASK [haproxy : Checking free port for Keystone Internal HAProxy] ****************************************************************************************************************************
 [WARNING]: when statements should not include jinja2 templating delimiters such as {{ }} or {% %}. Found: {{ 'keystone_internal' not in haproxy_stat }}

skipping: [node1]
 [WARNING]: when statements should not include jinja2 templating delimiters such as {{ }} or {% %}. Found: {{ 'keystone_internal' not in haproxy_stat }}

Reason: Ansible 2.3.0 does not like delimiters in when statement.

Related link: https://github.com/ansible/ansible/issues/22397

Duong Ha-Quang (duonghq)
summary: - In Ansible 2.3.1, when statement should not contain delimiters
+ In Ansible 2.3, when statement should not contain delimiters
description: updated
Changed in kolla-ansible:
assignee: nobody → Duong Ha-Quang (duonghq)
tags: added: low-hanging-fruit
Changed in kolla-ansible:
importance: Undecided → Medium
milestone: none → pike-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)

Fix proposed to branch: master
Review: https://review.openstack.org/470169

Changed in kolla-ansible:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.openstack.org/470169
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=dbedf6b6598ab69122b3bf9b97460d4a83f4af7d
Submitter: Jenkins
Branch: master

commit dbedf6b6598ab69122b3bf9b97460d4a83f4af7d
Author: Duong Ha-Quang <email address hidden>
Date: Fri Jun 2 13:04:56 2017 +0700

    Rewrite haproxy precheck conditions to not use string interpolation

    In Ansible 2.3.0 when statements should not include jinja2 templating
    delimiters such as {{ }} or {% %}

    This patchset fixes all condition in precheck task of haproxy.

    Change-Id: I5ad234cf24133efe342956c1b7ab1b947f96b20f
    Partial-Bug: #1695142

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/473206

Changed in kolla-ansible:
milestone: pike-2 → pike-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/ocata)

Reviewed: https://review.openstack.org/473206
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=f6a62845a80657bed84c0f273d6cced80f2e67f4
Submitter: Jenkins
Branch: stable/ocata

commit f6a62845a80657bed84c0f273d6cced80f2e67f4
Author: Duong Ha-Quang <email address hidden>
Date: Fri Jun 2 13:04:56 2017 +0700

    Rewrite haproxy precheck conditions to not use string interpolation

    In Ansible 2.3.0 when statements should not include jinja2 templating
    delimiters such as {{ }} or {% %}

    This patchset fixes all condition in precheck task of haproxy.

    Change-Id: I5ad234cf24133efe342956c1b7ab1b947f96b20f
    Partial-Bug: #1695142
    (cherry picked from commit dbedf6b6598ab69122b3bf9b97460d4a83f4af7d)

tags: added: in-stable-ocata
Changed in kolla-ansible:
milestone: pike-3 → pike-rc1
Changed in kolla-ansible:
milestone: pike-rc1 → pike-rc2
milestone: pike-rc2 → queens-1
Changed in kolla-ansible:
milestone: queens-2 → queens-3
Changed in kolla-ansible:
milestone: queens-3 → queens-rc1
Changed in kolla-ansible:
milestone: queens-rc1 → rocky-1
Changed in kolla-ansible:
milestone: rocky-2 → rocky-3
Changed in kolla-ansible:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.