kolla-ansible

Mismatch between OVS-DPDK task name and notify

Series antelope
Bug #2033413

Bug #2033413 reported by Juan Pablo Suazo on 2023-08-29

This bug affects 3 people

	Status	Importance	Assigned to
kolla-ansible	Status tracked in Bobcat
Antelope	Fix Committed	Low	Unassigned
Bobcat	Fix Released	Low	Juan Pablo Suazo
Yoga	Invalid	Low	Unassigned
Zed	Fix Committed	Low	Unassigned

Bug Description

In the file `ansible/roles/ovs-dpdk/handlers/main.yml`, the notify module on the `Restart ovsdpdk-db container` task calls the task `ovs-dpdk gather facts`, but the task name is actually: `OVS-DPDK gather facts`. The difference in capitalization results in the following error while deploying ovsdpdk:

RUNNING HANDLER [ovs-dpdk : Restart ovsdpdk-db container] **********************
ERROR! The requested handler 'ovs-dpdk gather facts' was not found in either the main handlers list nor in the listening handlers list

Thie error was introduced in the commit `Fix issues introduced by ansible-lint 6.6.0`(I6f52f2b0c1ef76de626657d79486d31e0f47f384), presumably when addressing a linter error, but the code wasn't refactored.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-08-29: Fix proposed to kolla-ansible (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/892613

Changed in kolla-ansible:
status:	New → In Progress

Juan Pablo Suazo (jsuazo) on 2023-08-29

Changed in kolla-ansible:
assignee:	nobody → Juan Pablo Suazo (jsuazo)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-08-30: Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/892613
Committed: https://opendev.org/openstack/kolla-ansible/commit/95317e5df28cc6641cb705b4c2dd5c9cf20d5586
Submitter: "Zuul (22348)"
Branch: master

commit 95317e5df28cc6641cb705b4c2dd5c9cf20d5586
Author: Juan Pablo Suazo Sarrocchi <email address hidden>
Date: Tue Aug 29 15:01:29 2023 +0000

Fixes task name in notify module to the actual task name

    An OVS-DPDK task had part of its name capitalized,
    presumably due to the newly added ansible linter,
    but this change was not reflected in the notify
    module which calls the task. This results in an
    inability to deploy openstack with OVS-DPDK.

This commit fixes the name of the task in the
notify module.

    Closes-Bug: #2033413
    Change-Id: Iae8a937bb2c35d2eb83e2c4522d829a6cfe25f0d
    Signed-off-by: Juan Pablo Suazo <email address hidden>

Changed in kolla-ansible:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-08-30: Fix proposed to kolla-ansible (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/893206

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-08-30: Fix proposed to kolla-ansible (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/893207

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-08-31: Fix proposed to kolla-ansible (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/893250

Revision history for this message

Maksim Malchuk (mmalchuk) wrote on 2023-09-06:

Yoga not affected, issue appears since 1aac65de0c60e6aef543995d42ff0ccd56f664d5 in Zed.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-09-06: Change abandoned on kolla-ansible (stable/yoga)

Change abandoned by "Michal Nasiadka <email address hidden>" on branch: stable/yoga
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/893250
Reason: not needed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-09-11: Fix merged to kolla-ansible (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/893206
Committed: https://opendev.org/openstack/kolla-ansible/commit/6955f956f9c087e6018bbb3c38f787a80eb06fb7
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 6955f956f9c087e6018bbb3c38f787a80eb06fb7
Author: Juan Pablo Suazo Sarrocchi <email address hidden>
Date: Tue Aug 29 15:01:29 2023 +0000

Fixes task name in notify module to the actual task name

This commit fixes the name of the task in the
notify module.

    Closes-Bug: #2033413
    Change-Id: Iae8a937bb2c35d2eb83e2c4522d829a6cfe25f0d
    Signed-off-by: Juan Pablo Suazo <email address hidden>
    (cherry picked from commit 95317e5df28cc6641cb705b4c2dd5c9cf20d5586)