init-runonce needs improvement

Bug #1772352 reported by Chason Chan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
In Progress
Undecided
Chason Chan

Bug Description

Currently, init-runonce will check if it has been run properly by checking whether an image named 'cirros' existed. But the example blew shows "openstack image create" command run failed, and init-runonce still configuring neutron and so on:

[root@kolla-aio tools]# ./init-runonce
No module named cryptography
Checking for locally available cirros image.
None found, downloading cirros image.
  % Total % Received % Xferd Average Speed Time Time Time Current
                                 Dload Upload Total Spent Left Speed
100 12.1M 100 12.1M 0 0 2670k 0 0:00:04 0:00:04 --:--:-- 2671k
Creating glance image.
No module named cryptography
Configuring neutron.
+---------------------------+--------------------------------------+
| Field | Value |
+---------------------------+--------------------------------------+
| admin_state_up | UP |
| availability_zone_hints | |
| availability_zones | |
| created_at | 2018-05-21T02:28:11Z |
| description | |
| dns_domain | None |
| id | 30794571-2e8c-4c95-834d-87290361b1e4 |
| ipv4_address_scope | None |
| ipv6_address_scope | None |
| is_default | False |
| is_vlan_transparent | None |
| mtu | 1500 |
| name | public1 |
| port_security_enabled | True |
| project_id | 70fd1808ad5046d491212b03226c9295 |
| provider:network_type | flat |
| provider:physical_network | physnet1 |
| provider:segmentation_id | None |
| qos_policy_id | None |
| revision_number | 1 |
| router:external | External |
| segments | None |
| shared | False |
| status | ACTIVE |
| subnets | |
| tags | |
| updated_at | 2018-05-21T02:28:11Z |
+---------------------------+--------------------------------------+

When I run init-runonce secondly, as you can see, this script won't exit as we expected. It cannot be ensure run just once.

The improvement is to check whether image created successfully. If true, then go on, else exit.

Chason Chan (chen-xing)
Changed in kolla-ansible:
assignee: nobody → Chason Chan (chen-xing)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)

Fix proposed to branch: master
Review: https://review.openstack.org/569708

Chason Chan (chen-xing)
summary: - init-runone need improvement
+ init-runonce need improvement
summary: - init-runonce need improvement
+ init-runonce needs improvement
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on kolla-ansible (master)

Change abandoned by "Michal Nasiadka <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/569708
Reason: No updates since 2018

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.