init-runonce needs improvement
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
kolla-ansible |
In Progress
|
Undecided
|
Chason Chan |
Bug Description
Currently, init-runonce will check if it has been run properly by checking whether an image named 'cirros' existed. But the example blew shows "openstack image create" command run failed, and init-runonce still configuring neutron and so on:
[root@kolla-aio tools]# ./init-runonce
No module named cryptography
Checking for locally available cirros image.
None found, downloading cirros image.
% Total % Received % Xferd Average Speed Time Time Time Current
100 12.1M 100 12.1M 0 0 2670k 0 0:00:04 0:00:04 --:--:-- 2671k
Creating glance image.
No module named cryptography
Configuring neutron.
+------
| Field | Value |
+------
| admin_state_up | UP |
| availability_
| availability_zones | |
| created_at | 2018-05-
| description | |
| dns_domain | None |
| id | 30794571-
| ipv4_address_scope | None |
| ipv6_address_scope | None |
| is_default | False |
| is_vlan_transparent | None |
| mtu | 1500 |
| name | public1 |
| port_security_
| project_id | 70fd1808ad5046d
| provider:
| provider:
| provider:
| qos_policy_id | None |
| revision_number | 1 |
| router:external | External |
| segments | None |
| shared | False |
| status | ACTIVE |
| subnets | |
| tags | |
| updated_at | 2018-05-
+------
When I run init-runonce secondly, as you can see, this script won't exit as we expected. It cannot be ensure run just once.
The improvement is to check whether image created successfully. If true, then go on, else exit.
Changed in kolla-ansible: | |
assignee: | nobody → Chason Chan (chen-xing) |
status: | New → In Progress |
summary: |
- init-runone need improvement + init-runonce need improvement |
summary: |
- init-runonce need improvement + init-runonce needs improvement |
description: | updated |
Fix proposed to branch: master /review. openstack. org/569708
Review: https:/