eeschema undo: missing junctions when undoing delete.

Bug #1844620 reported by Dino Ghilardi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Committed
High
Jeff Young

Bug Description

Undo in eeschema (master branch) does not always work correctly.

To reproduce:
1) Select a block with some junctions.
2) Delete it (del key)
3) undo (ctrl-z).
   The un-done deleted part now does not have some of the junction symbols.

Attached there is a simple project to show the behaviour.

(See the attached images for the before-after the delete+undo operation).

Dragging the wires make the junctions on the dragged part re-appear, so it seems that the wire is connected but without the junction symbol.

I also had a (probably) related issue on undoing operations on much more complex schematics, where also bus segments appear like they were copied from somewhere else, but that is quite erratic and I did not find (yet) a way to reproduce that in a deterministic (and simple) way.

Note: Stable version 5.1.4 works correctly.

Cheers, Dino.

------------------------------
Application: Eeschema
Version: (5.99.0-139-gbb596ebda-dirty), release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.52.1 OpenSSL/1.0.2s zlib/1.2.8 libidn2/0.16 libpsl/0.17.0 (+libidn2/0.16) libssh2/1.7.0 nghttp2/1.18.1 librtmp/2.3
Platform: Linux 4.9.0-8-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.52.1
    Compiler: GCC 6.3.0 with C++ ABI 1010

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Tags: eeschema
Revision history for this message
Dino Ghilardi (dino-ghilardi) wrote :
Revision history for this message
Dino Ghilardi (dino-ghilardi) wrote :
Revision history for this message
Dino Ghilardi (dino-ghilardi) wrote :
description: updated
description: updated
Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

I'm setting the priority of this to high since it leads to a broken schematic.

Changed in kicad:
status: New → Triaged
importance: Undecided → High
milestone: none → 6.0.0-rc1
Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

@Dino, nice bug report. Thanks for providing everything I needed to duplicate this bug and for confirming that it doesn't occur in the 5.1 branch. This makes the members of the bug squad's life much easier. Thanks.

Jeff Young (jeyjey)
Changed in kicad:
assignee: nobody → Jeff Young (jeyjey)
Jeff Young (jeyjey)
Changed in kicad:
status: Triaged → In Progress
Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 33606431ccb8feb1d4ba4f3e6cdddd4196e12fd6
https://git.launchpad.net/kicad/patch/?id=33606431ccb8feb1d4ba4f3e6cdddd4196e12fd6

Changed in kicad:
status: In Progress → Fix Committed
tags: added: eeschema
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.