KiCad

Page layout editor File->quit menu not working

Bug #1832139 reported by Dino Ghilardi on 2019-06-09

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	KiCad	Fix Committed	Low	Ian McInerney	KiCad 6.0.0-rc1

Bug Description

Trying to exit page layout editor with CTRL+Q or File->Quit does not work.

Closing the window clicking the "X" on the window bar works.
Tested on revision: 929b1a1275040f40f0281d011080c0c42c790ebb

Note: in version 5.1.2 File->Close works correctly.

--------------------------------------------------
Application: PlEditor
Version: (5.1.0-907-g929b1a127), release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.52.1 OpenSSL/1.0.2r zlib/1.2.8 libidn2/0.16 libpsl/0.17.0 (+libidn2/0.16) libssh2/1.7.0 nghttp2/1.18.1 librtmp/2.3
Platform: Linux 4.9.0-8-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.52.1
    Compiler: GCC 6.3.0 with C++ ABI 1010

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Tags:

Michael Kavanagh (michaelkavanagh) on 2019-06-10

tags:

added: pleditor
removed: pl-edit

Jeff Young (jeyjey) on 2019-06-10

Changed in kicad:
assignee:	nobody → Jeff Young (jeyjey)
milestone:	none → 6.0.0-rc1
importance:	Undecided → Low
status:	New → In Progress

Jeff Young (jeyjey) on 2019-06-11

Changed in kicad:
status:	In Progress → Fix Committed

Revision history for this message

Konstantin Baranovskiy (baranovskiykonstantin) wrote on 2019-08-01:

Status is changed to "Fix committed" but the latest master (9dcf3b862c0cf260c2e57d092d517fce783268a9) is still affected by this issue.
"File->Page settings..." also doesn't work.

Application: PlEditor
Version: (5.1.0-1400-g9dcf3b862), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.65.3 OpenSSL/1.1.1c zlib/1.2.11 libidn2/2.2.0 libpsl/0.21.0 (+libidn2/2.2.0) libssh2/1.8.2 nghttp2/1.36.0
Platform: Linux 5.2.4-arch1-1-ARCH x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.65.3
    Compiler: GCC 9.1.0 with C++ ABI 1013

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Ian McInerney (imcinerney) on 2019-08-01

Changed in kicad:
status:	Fix Committed → Confirmed

Revision history for this message

Ian McInerney (imcinerney) wrote on 2019-08-01:

Yep, still an issue.

Ian McInerney (imcinerney) on 2019-08-01

Changed in kicad:
assignee:	Jeff Young (jeyjey) → Ian McInerney (imcinerney)
status:	Confirmed → In Progress

Revision history for this message

Ian McInerney (imcinerney) wrote on 2019-08-01:

@Jeff, I am thinking that the preview settings should be moved out of the file menu since they aren't going to be saved with the file, and in the file menu users could mistake it as behaving like the other applications (since those page settings are in the file menu). I am torn between edit and view, have a preference?

Revision history for this message

Jeff Young (jeyjey) wrote on 2019-08-02:

@Ian, the View menu would do the most to communicate the "Preview" nature, so I'd lean that way.

Revision history for this message

Ian McInerney (imcinerney) wrote on 2019-08-02:

0001-pleditor-Fix-menubar-actions-and-display.patch Edit (6.8 KiB, text/plain)

Ok, here is a patch that fixes the menubar.

I added the same quit logic that the other programs have, but it appears that the editor is always launched as a single program, so it is only able to exit from itself not the entire program.

Michael Kavanagh (michaelkavanagh) on 2019-08-02

tags:

added: ui

Revision history for this message

KiCad Janitor (kicad-janitor) wrote on 2019-08-02:

Fixed in revision c258ad7e3c5744618264b38e29e364731b7369f2
https://git.launchpad.net/kicad/patch/?id=c258ad7e3c5744618264b38e29e364731b7369f2