KiCad

KiCAD 5.1 -- Footprint editor, Menu "Import footprint from KiCAD file"

Bug #1822907 reported by Cal-linux on 2019-04-02

6

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	KiCad	Fix Committed	Low	Michael Kavanagh	KiCad 6.0.0-rc1

Bug Description

The menu item (under "File") actually says "Import footprint from KiCAD file", but that leads to a dialog where one can import different types of footprints, including gEDA footprints.

It should NOT say "from KiCAD file".

KiCAD version:

Application: kicad
Version: 5.1.0-060a0da~80~ubuntu18.04.1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.58.0 OpenSSL/1.1.0g zlib/1.2.11 libidn2/2.0.4 libpsl/0.19.1 (+libidn2/2.0.4) nghttp2/1.30.0 librtmp/2.3
Platform: Linux 4.15.0-46-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.22
    Boost: 1.65.1
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.58.0
    Compiler: GCC 7.3.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Tags:

Revision history for this message

Michael Kavanagh (michaelkavanagh) wrote on 2019-04-03:

#1

0001-Make-footprint-editor-import-menu-less-confusing.patch Edit (2.5 KiB, text/plain)

Revision history for this message

eelik (eelik) wrote on 2019-04-03:

#2

@Michael: why not just be less verbose: "Import Footprint from File"? It can safely be assumed that the file is existing without being explicit about that. Like, menus never have "Open Existing File" etc.

Revision history for this message

Michael Kavanagh (michaelkavanagh) wrote on 2019-04-03:

#3

@eelik - Agreed, but I was going for minimal string changes.

Revision history for this message

Michael Kavanagh (michaelkavanagh) wrote on 2019-04-03:

#4

0001-Clean-up-import-and-export-menus.patch Edit (4.7 KiB, text/plain)

A slightly more invasive but IMO better change.

tags:

added: ui

Revision history for this message

Cal-linux (cal-linux) wrote on 2019-04-03:

#5

If I'm understanding correctly the suggested change --- the text "Create a SVG file from current symbol" is being added (I guess that's the tooltip text?).

Shouldn't it be "Create an SVG..."? If you read it like the acronym (i.e., ess-vee-gee), then it would have to be AN; if you read it like "Scalable Vector...", it would be A; but being written with the acronym, I guess it should be AN?

Revision history for this message

Cal-linux (cal-linux) wrote on 2019-04-03:

#6

For that matter --- can that article be removed? (I think it could be "Create SVG from ...."). Similarly, it could (maybe even should) be "Import footprint from file", instead of "Import a footprint from file".

Revision history for this message

Michael Kavanagh (michaelkavanagh) wrote on 2019-04-03:

#7

No, this is grouping the export options in the Symbol Editor menubar into an Export Submenu (like the other applications). There is no change to that menu items help text.

Michael Kavanagh (michaelkavanagh) on 2019-04-04

Changed in kicad:
importance:	Undecided → Low
milestone:	none → 6.0.0-rc1
status:	New → Triaged

Revision history for this message

Michael Kavanagh (michaelkavanagh) wrote on 2019-04-05:

#8

0001-Clean-up-import-and-export-menus.patch Edit (4.7 KiB, text/plain)

Rebased onto latest menubar changes.

Revision history for this message

Wayne Stambaugh (stambaughw) wrote on 2019-05-02:

#9

@Michael, your patch looks fine. Did you decide not move "Export Footprint..." and "Export View as PNG..." into a common "Export" sub-menu in the footprint editor for a specific reason or was it just an oversight?

Revision history for this message

Michael Kavanagh (michaelkavanagh) wrote on 2019-05-02:

#10

0001-Clean-up-import-and-export-menus.patch Edit (5.7 KiB, text/plain)

@Wayne, must have been an oversight (didn't notice it at the bottom of the menu). I have attached an updated patch.

Revision history for this message

KiCad Janitor (kicad-janitor) wrote on 2019-05-02:

#11

Fixed in revision 2a09664ebce0b4c03be14588c15e697a0560a58b
https://git.launchpad.net/kicad/patch/?id=2a09664ebce0b4c03be14588c15e697a0560a58b

Changed in kicad:
status:	Triaged → Fix Committed
assignee:	nobody → Michael Kavanagh (michaelkavanagh)

Revision history for this message

Wayne Stambaugh (stambaughw) wrote on 2019-05-02:

#12

@Michael, I merged your patch into the master branch. I don't think I will cherry pick this into 5.1. It's probably not a good idea to rearrange menus during a stable release series if we don't have to. Thank you for your contribution.

Revision history for this message

Michael Kavanagh (michaelkavanagh) wrote on 2019-05-02:

#13

@Wayne thanks. Sure, no problem, thats why I set the milestone for 6.0.0-rc1.

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Patches

Add patch

Remote bug watches

Bug watches keep track of this bug in other bug trackers.