PCBnew clarify selection menu doesn't highlight items on MSW

Is this still broken in Windows?
It's also broken in MacOS: see https://bugs.launchpad.net/kicad/+bug/1715440
If it doesn't work in Windows, I'm guessing it's the same problem -- paint events are not generated when the context menu is open.

Yes: no item highlight on Windows.

Can someone try this patch on Windows and see if it fixes the issue?

@Jeff,
Yes, it fixes this issue on Windows.

Is this patch ready for commit?

Thanks.

@JP, yes, it's the same patch that's been in Mac for months now, just changed to compile everywhere but Unix.

> On 11 Feb 2018, at 10:53, jean-pierre charras <email address hidden> wrote:
>
> @Jeff,
> Yes, it fixes this issue on Windows.
>
> Is this patch ready for commit?
>
> Thanks.
>
> --
> You received this bug notification because you are a member of KiCad Bug
> Squad, which is subscribed to KiCad.
> https://bugs.launchpad.net/bugs/1594029
>
> Title:
> PCBnew clarify selection menu doesn't highlight individual selection
>
> Status in KiCad:
> Confirmed
>
> Bug description:
> If I am to select an object that intersect with another( tracks for example) Pcbnew pulls down a menu that asks me to clarify selection, in linux it highlights each track with green stroke if I hover over it in the menu, I started using the program in windows and this behavior doesn't exist. you have to choose from the information related to the track you want to select.
> ____________________________________________________
>
> Application: kicad
> Version: no-bzr-kicad_new3d-viewer, debug build
> Libraries: wxWidgets 3.0.2
> libcurl/7.46.0 OpenSSL/1.0.2d zlib/1.2.8 libidn/1.32 libssh2/1.6.0 librtmp/2.3
> Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
> - Build Info -
> wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8)
> Boost: 1.57.0
> Curl: 7.46.0
> KiCad - Compiler: GCC 5.2.0 with C++ ABI 1009
> Settings: USE_WX_GRAPHICS_CONTEXT=OFF
> USE_WX_OVERLAY=OFF
> KICAD_SCRIPTING=ON
> KICAD_SCRIPTING_MODULES=ON
> KICAD_SCRIPTING_WXPYTHON=ON
> USE_FP_LIB_TABLE=HARD_CODED_ON
> BUILD_GITHUB_PLUGIN=ON
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1594029/+subscriptions

Fixed in revision a7cdd94212582f33230afad8ca9d0c2d2358b491
https://git.launchpad.net/kicad/patch/?id=a7cdd94212582f33230afad8ca9d0c2d2358b491

@JP, could you please merge this one more time? I managed to break OSX. (__UNIX__ *is* defined for OSX. Well, duh.)

Jeff, no worries - I merged your patch.

Should this work with the latest (14.2.) Windows nightly build? Because it doesn't. No hightlighing board items when the clarification menu is hovered over.

Application: kicad
Version: (2018-02-14 revision 6afdf1cf8)-makepkg, release build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.54.1 OpenSSL/1.0.2l zlib/1.2.11 libssh2/1.8.0 nghttp2/1.23.1 librtmp/2.3
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.60.0
    Curl: 7.54.1
    Compiler: GCC 7.1.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON

*****************************************

Intel(R) HD Graphics

DirectX* Version: 11.0

* Processor Graphics Information *

Processor Graphics in Use: Intel(R) HD Graphics
Video BIOS: 2102.0
Current Graphics Mode: 1920 by 1200

Yes, it should.

I just tested on Mac and it's working so it's not totally broken.

What were you trying to highlight? The footprint highlighting is kind of subtle as it only highlights the anchor cross rather than the whole footprint. But otherwise it sounds like it might be broken again on Windows?

(FWIW I have a fix for the only-highlights-the-anchor thing, but it's in my 6.0 tree so won't see the light of day till 5.0RC is branched.)

Tracks, vias, pads, footprints (for example). It works on Linux for me so I know how it looks like. Nothing on this Win7 setup.

It works for me on W7 32 bits.

Is this working for others on Windows? (All I've got is a Mac, so I'm a bit in the dark here.)

I'll ask in the users' forum. There might be people there who don't follow the bug reports or git logs. This feature is easy to miss on Windows because most users, even nightly users, probably use only one platform or another and aren't aware of the existence of the feature if they don't see it.

Unfortunately, it does not work for me on Windows 7.

I'm seeing this problem on w7 pro 64-bit. It appears to just be a
problem with the 64 bit version of windows.

On 2/15/2018 9:51 AM, jean-pierre charras wrote:
> It works for me on W7 32 bits.
>

After more tests on W7/32 bits:

* Compiled with wxWidgets 3.03+wxPython:
Highlight does not work.

* Compiled with wxWidgets 3.10 (without wxPython, not available):
Highlight works.

@Orson, I just noticed that we also support background highlighting of nets from within the List Nets dialog. Does that work on MSW? (If so, it might provide a method of fixing selection highlighting.)

IIRC the problem on MSW are the pop-up menus - once they appear, they get full attention, so one cannot refresh the canvas. It is easy with another window opened like in List Nets dialog case.

Bummer. It really is a great feature.

This affects also the DRC dialog's list. Bummer, really. It would be so much easier to find the problem with highlight. Could it be possible to get rid of the menu here altogether and detect hovering over the list items? As far as I can see each board item is in its own row.

The tooltip of the list gives false information in Windows because "Right click to highlight items" doesn't work.

Fixed in revision f21faceb7463ac413ee6d875cf90629cc2d4e555
https://git.launchpad.net/kicad/patch/?id=f21faceb7463ac413ee6d875cf90629cc2d4e555