fails to log auth headers, request logging incomplete
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
keystoneauth |
Triaged
|
Wishlist
|
Unassigned |
Bug Description
If you enable debug logging the logging of requests performed by Session.
Session.request does this:
if requests_auth:
just before calling self._http_
In the case of SAML ECP the requests_auth callback is:
keystoneauth1.
which modifies the request headers, but the auth callback is not invoked until send() is called which is after the request is logged. The net result is the headers set the by the auth callback are missing from the logged request making it look as if the request is malformed.
The logging should either be performed at the moment the request is emitted by python-requests (not sure but there may be a hook for this) or after the request returns.
Changed in keystoneauth: | |
importance: | Undecided → Low |
status: | New → Triaged |
Changed in keystoneauth: | |
assignee: | nobody → John Dennis (jdennis-a) |
Changed in keystoneauth: | |
importance: | Low → Wishlist |
Automatically unassigning due to inactivity.