OpenStack Identity (keystone)

Deprecate config options with 'tenant' in the name and replace with 'project' (LDAP)

Bug #1283841 reported by Morgan Fainberg
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Wishlist
Dolph Mathews
OpenStack Identity (keystone) 2014.2 "juno"

Bug Description

Configuration options with 'tenant' in the name should be deprecated in favor of configuration options with 'project' in the name. This mostly applies to the options in LDAP section of the config (keystone.common.config)

Morgan Fainberg (mdrnstm)
Changed in keystone:
status: New → Triaged
importance: Undecided → Wishlist
shihanzhang (shihanzhang)
Changed in keystone:
assignee: nobody → shihanzhang (shihanzhang)
Revision history for this message
Morgan Fainberg (mdrnstm) wrote :

Any option that is deprecated needs to still "work" for 2 releases. I believe the correct nomenclature is to specify a list of oslo.config deprecated option objects to the 'deprecated_ops' kwarg on the option definition.

Eg.

cfg.StrOpt('project_name_attribute', default='ou',
                   help='LDAP attribute mapped to project name',
                   deprecated_opts=[cfg.DeprecatedOpt('tenant_name_attribute', group='ldap'),])

Revision history for this message
shihanzhang (shihanzhang) wrote :

I agree with you!

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/75780

Changed in keystone:
status: Triaged → In Progress
Revision history for this message
Dolph Mathews (dolph) wrote :

Related: https://bugs.launchpad.net/horizon/+bug/1017606

Dolph Mathews (dolph)
Changed in keystone:
milestone: none → juno-1
status: In Progress → Triaged
shihanzhang (shihanzhang)
Changed in keystone:
assignee: shihanzhang (shihanzhang) → nobody
Dolph Mathews (dolph)
Changed in keystone:
milestone: juno-1 → juno-2
Dolph Mathews (dolph)
Changed in keystone:
assignee: nobody → Dolph Mathews (dolph)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/102278

Changed in keystone:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/102278
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=58fb7978152002f713d2bfcdf27d7ee69b3f2823
Submitter: Jenkins
Branch: master

commit 58fb7978152002f713d2bfcdf27d7ee69b3f2823
Author: Dolph Mathews <email address hidden>
Date: Tue Jun 24 10:28:01 2014 -0500

    deprecate LDAP config options for 'tenants'

    This deprecates all config options using the term 'tenant' in favor of
    new options using the term 'project'.

    Change-Id: I7eb6819de33f4d94a8bae75286bb02436152c64b
    Closes-Bug: 1283841

Changed in keystone:
status: In Progress → Fix Committed
Russell Bryant (russellb)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.